[Bug 8336] New: SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Priority: P5 - low Change sponsored?: --- Bug ID: 8336 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: SIP Server does not process renewal transaction correctly Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: SIP2 Product: Koha Sip renewal transactions are rejected by bogus error messages. If we suppress that it is not setting some data correctly e.g. the new duedate. Most people will not notice this as selfcheck units use the checkout transaction to do renewal, however if you want to use Itiva/Talking Tech telephone renewals you need to support this transaction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 10567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10567&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Tested by Staffordshire University with help from Talking Tech -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10567|0 |1 is obsolete| | --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 12035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12035&action=edit Revised Patch Cleaned up the code. Handle some cases better - rebased against current master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Changed status to bug as without this patch the SIPServer crashes when faced with a RenewAll transaction. Also the current sip server reports to the client that it supports Renew and Renewall transactions but it does not and in ways that cause the client and/or server to fail. Tested by Staffordshire University with Talking Tech telephone renewals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12035|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12260&action=edit Bug 8336 Support Sip Renewal Transaction Renewals were being rejected for incorrect reasons Checking was being done against the wrong object Add more informative messages on failure Correctly set due_date for renewal response Avoid crashing the SIPServer because it handles RenewAll incorrectly Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
$ koha-qa.pl patch looks good, passing QA… testing 1 commit(s) (applied to commit 2a60d49) * 551c673 Bug 8336 Support Sip Renewal Transaction C4/SIP/ILS.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm C4/SIP/Sip/MsgType.pm * C4/SIP/ILS.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK * C4/SIP/Sip/MsgType.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (patch untested by me though) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org