[Bug 19776] New: Test failing randomly - fix categorycode vs category_type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Bug ID: 19776 Summary: Test failing randomly - fix categorycode vs category_type Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19529
From CanBookBeIssued: 726 if ( $patron->category->category_type eq 'X' && ( $item->{barcode} )) {
Tests are failing randomly if the category_type of the patron is 'X'. The previous tries to fix this issue set categorycode='X' (QAers, what are you doing?) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19517, 19487, 19455, 19423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 [Bug 19423] DecreaseLoanHighHolds.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487 [Bug 19487] Internal server error when writing off lost fine for item not checked out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19517 [Bug 19517] dateexpiry.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403 [Bug 19403] Again and again, Circulation.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69619&action=edit Bug 19776: Fix random failures (category_type vs categorycode='X') Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69805&action=edit Bug 19776: (follow-up) remove dup category_type keys The previous patch was obviously wrong, the category_type key appeared twice. categories.category_type is a varchar(1) and 'P' is not 'X'. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Skipping for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Bug 19776 depends on bug 19423, which changed state. Bug 19423 Summary: DecreaseLoanHighHolds.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Bug 19776 depends on bug 19403, which changed state. Bug 19403 Summary: Again and again, Circulation.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org