[Bug 27208] New: Add a configurable time delay feature to notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Bug ID: 27208 Summary: Add a configurable time delay feature to notice templates Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org It would be helpful to have a configurable time delay feature added to the notice templates. In our case, items with holds are immediately trapped, and the hold notice gets sent, when they get returned through our sorter. However, we are quarantining materials for 72 hours so we don’t want the hold pickup notice sent until the items come out of quarantine. Other possible uses for a configurable time delay might be when one library in a system is quarantining items but another is not. In a consortium, with a mix of school and public libraries, they might want to send notices at different times. Other libraries have mentioned their patrons arrive at the library because they got their pickup notice but staff hasn’t actually had time to process the holds. This would be especially helpful with hold notices but could also apply to other notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #1 from Rebecca Coert <rcoert@arlingtonva.us> --- +1 This would be very useful for all types of notices. Setting a "send time" for each notice type would make this fully customizable for a multitude of reasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen@ub.lu.se --- Comment #2 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128387&action=edit Bug 27208: Add a user specified delay before sending pickup notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #3 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128388&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bjorn.nylen@ub.lu.se |ity.org | Status|NEW |ASSIGNED --- Comment #4 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128389&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #5 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128390&action=edit Bug 27208: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Proposing this solution. Th patch adds a new column to the message_queue, delay_until, that contains a time that the notice should be delayed until. Om the returns page there are a new circulation setting, Delay pickup notice until, where the librarian can set a time the notice will be delyed until. On the patron account notice log, there will be a note indicating the delayed messages.(pending, delayed until [datetime]) For us the main usage in our stacks where books are processed as they are picked but they might not be available for the patron until a few hours later in the day. The change to the message queue should be backwards compatible as the delay_until will be set to null unless a time is provided and those messages will be processed as before. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in an item with a hold to produce a pickup notice. 3. Select a time for pickup notice delay. Note the warning about the delay. 4. Check in another item with hold to produce a pickup notice. 5. Check the patron notice logs, the one with a delay should read "pending, delayed until ...". 6. Run process_message_queue.pl before and after the selected time above. The delayed message should not be sent until after the set time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Björn, thx for your patches! Some first things I noticed: 1) QA test tools There are some problems noticed by the QA test tools. It's a good habit to run them yourself before submitting patches to catch these kind of things: FAIL circ/returns.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/atomicupdate/bug_27208-add_delay_util_to_message_queue.pl FAIL file permissions File must have the exec flag FAIL valid Useless use of anonymous hash ({}) in void context FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL forbidden patterns forbidden pattern: console.log (line 1167) 2) Authorship of patches The first 2 patches don't have your authorship: Author: root <root@9b7442205204> 3) Functionality It looks like this will allow for manually setting a time until the notice will be delayed on the checkin page. I am not sure if this is what Barbara had in mind here as it won't work for self checkins using the web based checkin or the RFID based ones. - And it also might be quite easy to get things confused if you have multiple circulation desks. I wonder if it would not be easier/better to make this a configuration setting, but probably a little harder to do. I am thinking circulation rules, since you might want to differentiate for different branches, but possibly a global setting could also be a good starting point. What do others think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #8 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Thx for pointing out the qa-tools, will correct the patches. For the functionality, we feel that it's neccessary for staff to be able to set the delay depending on situation, even within the same library. Controling it through circ-rules might be an issue depending on the whether rules are set by holdig or home branch. The processing is obviously done the holding branch but circ rules may be set according the the homebranch? One solution may be to have a syspref eg. PickupNoticeDelayMode that can be set to off|fixed|staff that controls how a delay is set, and a PickupNoticeDelayDuration pref to set the fixed time. Should be fairly straightforward to implement, a fixed duration could be calculated in ModReserveAffect to capture both staff and selfcheck machines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128387|0 |1 is obsolete| | Attachment #128388|0 |1 is obsolete| | Attachment #128389|0 |1 is obsolete| | Attachment #128390|0 |1 is obsolete| | --- Comment #9 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128587&action=edit Bug 27208: Add a user specified delay before sending pickup notices. This bug adds the ability to delay sending a notice until a set timestamp. It also adds a user selectable time on the returns page to delay sending of the pickup notice. The notice delay will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in an item with a hold to produce a pickup notice. 3. Select a time for pickup notice delay. Note the warning about the delay. 4. Check in another item with hold to produce a pickup notice. 5. Check the patron notice logs, the one with a delay should read "pending, delayed until ...". 6. Run process_message_queue.pl before and after the selected time above. The delayed message should not be sent until after the set time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #10 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128588&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #11 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128589&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #12 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128590&action=edit Bug 27208: Unit tests This commit adds unit test for changes in C4/Letters.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #13 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Updated patches that passed the qa-tools. Set back to Needs signoff and awaiting any comments on the functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #14 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- We use an automated materials handling system. As items are returned through the sorter holds are trapped, sorted, checked in and a hold pickup slip is generated. This all happens via SIP outside of Koha. So for our library we would be looking for an automated setting to control the delay rather than having to re-checkin the item in Koha and manually select a notice delay for each item. I like the idea of a system pref such as the suggested PickupNoticeDelayMode and the PickupNoticeDelayDuration pref to set the the amount of delay. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128587|0 |1 is obsolete| | Attachment #128588|0 |1 is obsolete| | Attachment #128589|0 |1 is obsolete| | Attachment #128590|0 |1 is obsolete| | --- Comment #15 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128948&action=edit Bug 27208: Add the ability to delay pickup notices. This bug adds the ability to delay sending a pickup notice. This can be done in two ways, either by a fixed configurable delay of all pickup notices or a time selectable by staff at checkin. This is controlled by two new system preferences, PickupNoticeDelayMode and PickupNoticeDelayDuration. A delayed notice will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in items with holds with different delay modes ('no delay','fixed delay','selectable by staff'). 3. Check the patron notice logs to check notice delay. Delayed notices have status 'pending, delayed until...' 4. Expected behaviour is: 'No delay': No notices are delayed. 'Fixed delay': All pickup notices are delayed by the no of hours set in PickupNoticeDelayDuration. 'Delay selectable by staff': Pickup notice is delayed until the time set in UI. If no delay is set, notice will not be delayed. Also note the warning at the checkin page when a delay is set. 5. Run process_message_queue.pl before and after the delay times above. Notices without delay are sent immediatly, delayed notices are only sent after the set time. 6. Tests should pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #16 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128949&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #17 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128950&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #18 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 128951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128951&action=edit Bug 27208: Unit tests This commit adds unit test for changes in C4/Letters.pm and C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #19 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Updated patch. Behavior is now controlled by PickupNoticeDelayMode and allows either a fixed delay or one set by the librarian at checkin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (This is just a side note but I wonder if another way of doing this would be implementing a TTL mechanism.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a configurable time |Add a configurable time |delay feature to notice |delay feature to hold |templates |notice templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Patchset does not apply cleanly to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes@ub.lu.se Assignee|bjorn.nylen@ub.lu.se |kevin.carnes@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128948|0 |1 is obsolete| | Attachment #128949|0 |1 is obsolete| | Attachment #128950|0 |1 is obsolete| | Attachment #128951|0 |1 is obsolete| | --- Comment #22 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 194480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194480&action=edit Bug 27208: Add the ability to delay pickup notices. This bug adds the ability to delay sending a pickup notice. This can be done in two ways, either by a fixed configurable delay of all pickup notices or a time selectable by staff at checkin. This is controlled by two new system preferences, PickupNoticeDelayMode and PickupNoticeDelayDuration. A delayed notice will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in items with holds with different delay modes ('no delay','fixed delay','selectable by staff'). 3. Check the patron notice logs to check notice delay. Delayed notices have status 'pending, delayed until...' 4. Expected behaviour is: 'No delay': No notices are delayed. 'Fixed delay': All pickup notices are delayed by the no of hours set in PickupNoticeDelayDuration. 'Delay selectable by staff': Pickup notice is delayed until the time set in UI. If no delay is set, notice will not be delayed. Also note the warning at the checkin page when a delay is set. 5. Run process_message_queue.pl before and after the delay times above. Notices without delay are sent immediatly, delayed notices are only sent after the set time. 6. Tests should pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194480|0 |1 is obsolete| | --- Comment #23 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 194481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194481&action=edit Bug 27208: Add the ability to delay pickup notices. This bug adds the ability to delay sending a pickup notice. This can be done in two ways, either by a fixed configurable delay of all pickup notices or a time selectable by staff at checkin. This is controlled by two new system preferences, PickupNoticeDelayMode and PickupNoticeDelayDuration. A delayed notice will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in items with holds with different delay modes ('no delay','fixed delay','selectable by staff'). 3. Check the patron notice logs to check notice delay. Delayed notices have status 'pending, delayed until...' 4. Expected behaviour is: 'No delay': No notices are delayed. 'Fixed delay': All pickup notices are delayed by the no of hours set in PickupNoticeDelayDuration. 'Delay selectable by staff': Pickup notice is delayed until the time set in UI. If no delay is set, notice will not be delayed. Also note the warning at the checkin page when a delay is set. 5. Run process_message_queue.pl before and after the delay times above. Notices without delay are sent immediatly, delayed notices are only sent after the set time. 6. Tests should pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #24 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 194482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194482&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #25 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 194483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194483&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #26 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 194484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194484&action=edit Bug 27208: Unit tests This commit adds unit test for changes in C4/Letters.pm and C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org