[Bug 40765] New: Acquisition tests will fail if order.quantity is set to 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Bug ID: 40765 Summary: Acquisition tests will fail if order.quantity is set to 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org When using TestBuilder to build an order the tests will fail when the object will be saved: 00:09:41 koha-1 | # Looks like you planned 58 tests but ran 26. 00:09:41 koha-1 | 00:09:41 koha-1 | # Failed test 'cancel() tests' 00:09:41 koha-1 | # at t/db_dependent/Koha/Acquisition/Order.t line 1042. 00:09:41 koha-1 | Cannot insert order: Mandatory parameter quantity is missing at t/db_dependent/Koha/Acquisition/Order.t line 868. 00:09:41 koha-1 | # Looks like your test exited with 255 just after 14. 00:09:41 koha-1 | [22:03:54] t/db_dependent/Koha/Acquisition/Order.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186255&action=edit Bug 40765: Prevent acquisition tests to fail if order.quantity = 0 When using TestBuilder to build an order the tests will fail when the object will be saved: 00:09:41 koha-1 | # Looks like you planned 58 tests but ran 26. 00:09:41 koha-1 | 00:09:41 koha-1 | # Failed test 'cancel() tests' 00:09:41 koha-1 | # at t/db_dependent/Koha/Acquisition/Order.t line 1042. 00:09:41 koha-1 | Cannot insert order: Mandatory parameter quantity is missing at t/db_dependent/Koha/Acquisition/Order.t line 868. 00:09:41 koha-1 | # Looks like your test exited with 255 just after 14. 00:09:41 koha-1 | [22:03:54] t/db_dependent/Koha/Acquisition/Order.t This happened on Koha_Main/3350 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com CC| |lucas@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186255|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186266&action=edit Bug 40765: Prevent acquisition tests to fail if order.quantity = 0 When using TestBuilder to build an order the tests will fail when the object will be saved: 00:09:41 koha-1 | # Looks like you planned 58 tests but ran 26. 00:09:41 koha-1 | 00:09:41 koha-1 | # Failed test 'cancel() tests' 00:09:41 koha-1 | # at t/db_dependent/Koha/Acquisition/Order.t line 1042. 00:09:41 koha-1 | Cannot insert order: Mandatory parameter quantity is missing at t/db_dependent/Koha/Acquisition/Order.t line 868. 00:09:41 koha-1 | # Looks like your test exited with 255 just after 14. 00:09:41 koha-1 | [22:03:54] t/db_dependent/Koha/Acquisition/Order.t This happened on Koha_Main/3350 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186282&action=edit Bug 40765: Fix EDI.t I have no idea why this is fixing the test! Without this patch they fail: t/db_dependent/Koha/EDI.t .. 1/5 # Failed test '14 log lines recorded for passed invoice file' # at t/db_dependent/Koha/EDI.t line 725. # got: '12' # expected: '14' # Failed test 'Warn recorded for transferring items' # at t/db_dependent/Koha/EDI.t line 728. # 'Unmatched item at branch:WID' # doesn't match '(?^u:transferring.*)' # Failed test 'Warn recorded for transferring items' # at t/db_dependent/Koha/EDI.t line 728. # '' # doesn't match '(?^u:transferring.*)' # Failed test 'Warn recorded for unmatched item' # at t/db_dependent/Koha/EDI.t line 728. # '' # doesn't match '(?^u:Unmatched item at branch:.*)' # Looks like you failed 4 tests of 32. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40765 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #9 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org