[Bug 38361] New: Gender field does not include a Required if the field is set to required in PatronSelfRegistrationBorrowerMandatoryField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Bug ID: 38361 Summary: Gender field does not include a Required if the field is set to required in PatronSelfRegistrationBorrowerMandatoryField Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. PatronSelfRegistrationBorrowerMandatoryField, find Gender(sex) and mark it as required. 2. Go to the self registration form. No 'Required' label. Also, this field is different because of the radio buttons. You cannot select a non value here so it makes interacting with PatronSelfRegistrationBorrowerMandatoryField weird. Why is this field a set of radio buttons when no others are? Should it be a dropdown? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bosse@gustavsson.one Assignee|oleonard@myacpl.org |bosse@gustavsson.one Status|NEW |Needs Signoff --- Comment #1 from Bosse <bosse@gustavsson.one> --- Created attachment 199169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199169&action=edit Bug 38361 - Gender field does not include a Required if the field is set to required in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 --- Comment #2 from Bosse <bosse@gustavsson.one> --- I think a dropdown menu is the best way to go here, although I know there is another similar form in Intra where this also needs to be changed..... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199214&action=edit Bug 38361: Gender field does not include a Required if the field is set to required in PatronSelfRegistrationBorrowerMandatoryField Solves this bug and enhances the user experiance by replacing the old radio buttons with a less-confusing dropdown menu. Test plan: 1. Open the setting "PatronSelfRegistrationBorrowerMandatoryField", find Gender(sex) and mark it as not required. 2. Go to the self registration form. No 'Required' label under gender. 3. Go back to the setting "PatronSelfRegistrationBorrowerMandatoryField", find Gender(sex) and mark it as required. 4. Go to the self registration form. The 'Required' label is there. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the gender field release notes| |for the patron | |self-registration form so | |that if it is marked as | |mandatory using the | |PatronSelfRegistrationBorro | |werMandatoryField system | |preference, the form shows | |the field as "Required". | | | |It also replaces the radio | |buttons with a dropdown | |menu. --- Comment #4 from David Nind <david@davidnind.com> --- Suggestions for the patch so that it better matches the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages): Bug 38361: Include 'Required' if patron self-registration form gender field is mandatory Fixes the gender field for the patron self-registration form so that if it is marked as mandatory (PatronSelfRegistrationBorrowerMandatoryField system preference), the form shows the field as "Required". It also replaces the radio buttons with a dropdown menu. Test plan: 1. For the PatronSelfRegistrationBorrowerMandatoryField system preference, set the Gender (sex) field as required. 2. Go to the self registration form in the OPAC and note that there is no 'Required' label for the gender field (use a private/incognito window). 3. Attempt to submit the form (complete the other marked required fields) and note: - the gender field uses radio buttons - that you can't successfully submit the form without selecting a gender, even though there is no indication that it is required 4. Apply the patch and repeat steps 2-3. 5. Note that the gender field is now: - Marked as required - It now uses a dropdown list 6. Make sure you can successfully submit the form. 7. Set the Gender (sex) field as not required for the PatronSelfRegistrationBorrowerMandatoryField system preference. 8. Make sure you can successfully submit a self-registration without needing to complete the gender field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42639 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org