https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bosse@gustavsson.one Assignee|oleonard@myacpl.org |bosse@gustavsson.one Status|NEW |Needs Signoff --- Comment #1 from Bosse <bosse@gustavsson.one> --- Created attachment 199169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199169&action=edit Bug 38361 - Gender field does not include a Required if the field is set to required in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the gender field release notes| |for the patron | |self-registration form so | |that if it is marked as | |mandatory using the | |PatronSelfRegistrationBorro | |werMandatoryField system | |preference, the form shows | |the field as "Required". | | | |It also replaces the radio | |buttons with a dropdown | |menu. --- Comment #4 from David Nind <david@davidnind.com> --- Suggestions for the patch so that it better matches the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages): Bug 38361: Include 'Required' if patron self-registration form gender field is mandatory Fixes the gender field for the patron self-registration form so that if it is marked as mandatory (PatronSelfRegistrationBorrowerMandatoryField system preference), the form shows the field as "Required". It also replaces the radio buttons with a dropdown menu. Test plan: 1. For the PatronSelfRegistrationBorrowerMandatoryField system preference, set the Gender (sex) field as required. 2. Go to the self registration form in the OPAC and note that there is no 'Required' label for the gender field (use a private/incognito window). 3. Attempt to submit the form (complete the other marked required fields) and note: - the gender field uses radio buttons - that you can't successfully submit the form without selecting a gender, even though there is no indication that it is required 4. Apply the patch and repeat steps 2-3. 5. Note that the gender field is now: - Marked as required - It now uses a dropdown list 6. Make sure you can successfully submit the form. 7. Set the Gender (sex) field as not required for the PatronSelfRegistrationBorrowerMandatoryField system preference. 8. Make sure you can successfully submit a self-registration without needing to complete the gender field. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42639 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 202559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202559&action=edit Bug 38361: (QA follow-up) Set required variable for input validation Built-in validation checks weren't functioning because the variable required.sex was not getting set. Ensure that variable gets set, and remove manual validation code that is no longer needed. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.