[Bug 20573] New: Patron receives membership expiry notice but 'will expire soon' alert doesn't show for staff at checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Bug ID: 20573 Summary: Patron receives membership expiry notice but 'will expire soon' alert doesn't show for staff at checkout Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jyorio@esilibrary.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We've seen a situation a few times now, where a patron comes into the library and informs the staff that they received notice that their account is going to expire, but when staff go to the patron's account and click checkout, the message, "Attention: Expiration: Patron's card will expire soon. Patron's card expires on ...", doesn't appear. This issue happens when the patron comes into the library exactly 30 days from their expiration. In this case, MembershipExpiryDaysNotice = 30 days and NotifyBorrowerDeparture = 30 days. So for example, the patron's expiration date is 05/11/2018. On 4/11/2018 the patron gets their notice, as expected. They come into the library on 4/11/2018 and the checkout message alerting staff to the impending expiration message doesn't show. Checking the same account on 4/12/2018 shows the message "Attention: Expiration: Patron's card will expire soon. Patron's card expires on 05/11/2018 Renew or Edit Details" on the checkout screen. I would expect the staff to be alerted at checkout on 4/11/2018 since the patron has been notified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |emily.lamancusa@montgomeryc | |ountymd.gov Version|17.11 |Main Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Still valid! Currently, theses behaviors are controlled by two different system preferences: MembershipExpiryDaysNotice determines when an expiry notice is sent NotifyBorrowerDeparture determines when an alert is displayed on the patron's account page. However, the code for MembershipExpiryDaysNotice checks if the patron account will expire in *X days or less*, and the code for NotifyBorrowerDeparture checks if the patron account will expire in *less than* X days. If you set both preferences to the same value, one would expect the notice to be sent and the alert to start appearing on the same day, but with the current code, the alert begins showing one day later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- The unit tests specifically test for this case, which gave me pause for a moment on whether we should change the behavior. However, based on the comments on bug 17583 (where the test was added), it sounds like that test was added mainly because that was the existing behavior at the time and the question of whether that *should* be the behavior was out of scope. With that context, and the fact that it's confusing for two system preferences to behave differently when set to the same value, I think it's worth changing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 201406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201406&action=edit Bug 20573: Make NotifyBorrowerDeparture's date math consistent with MembershipExpiryDaysNotice To test: 1. Set both system preferences NotifyBorrowerDeparture and MembershipExpiryDaysNotice to 10 days 2. Create or edit a patron account with the following settings: - expiry date is exactly 10 days in the future - add an email address on the patron account - set messaging preferences to receive email notices for Patron account expiry 3. Run the membership expiry cron job to generate a notice: ktd --shell perl misc/cronjobs/membership_expiry.pl -c 4. Check notices tab on patron account --> A membership expiry notice has been queued for the patron 5. Click back to the patron details --> Note that there is no alert that the patron account will be expiring soon 6. Apply patch and restart_all 7. Refresh the patron details page --> You should now see an alert that the account will be expiring soon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a bug that release notes| |caused the system | |preferences | |MembershipExpiryDaysNotice | |and NotifyBorrowerDeparture | |to behave differently when | |set to the same value. For | |example, if | |MembershipExpiryDaysNotice | |and NotifyBorrowerDeparture | |are both set to trigger 30 | |days before the patron | |account expiration date, | |MembershipExpiryDaysNotice | |would cause an account | |expiry notice to be sent | |exactly 30 days before the | |account expiration date; | |however, | |NotifyBorrowerDeparture | |would not begin showing an | |alert on the patron account | |until the next day. This | |adjusts the timing on | |NotifyBorrowerDeparture to | |begin displaying the alert | |exactly the chosen number | |of days before the account | |expires. That way, if | |MembershipExpiryDaysNotice | |and NotifyBorrowerDeparture | |are set to the same value, | |they will both trigger on | |the same day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 202132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202132&action=edit Bug 20573: Make NotifyBorrowerDeparture's date math consistent with MembershipExpiryDaysNotice To test: 1. Set both system preferences NotifyBorrowerDeparture and MembershipExpiryDaysNotice to 10 days 2. Create or edit a patron account with the following settings: - expiry date is exactly 10 days in the future - add an email address on the patron account - set messaging preferences to receive email notices for Patron account expiry 3. Run the membership expiry cron job to generate a notice: ktd --shell perl misc/cronjobs/membership_expiry.pl -c 4. Check notices tab on patron account --> A membership expiry notice has been queued for the patron 5. Click back to the patron details --> Note that there is no alert that the patron account will be expiring soon 6. Apply patch and restart_all 7. Refresh the patron details page --> You should now see an alert that the account will be expiring soon Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|This fixes a bug that |This fixes a bug that release notes|caused the system |caused the system |preferences |preferences |MembershipExpiryDaysNotice |MembershipExpiryDaysNotice |and NotifyBorrowerDeparture |and NotifyBorrowerDeparture |to behave differently when |to behave differently when |set to the same value. For |set to the same value. |example, if | |MembershipExpiryDaysNotice |For example, if |and NotifyBorrowerDeparture |MembershipExpiryDaysNotice |are both set to trigger 30 |and NotifyBorrowerDeparture |days before the patron |are both set to trigger 30 |account expiration date, |days before the patron |MembershipExpiryDaysNotice |account expiration date: |would cause an account |- |expiry notice to be sent |MembershipExpiryDaysNotice |exactly 30 days before the |would cause an account |account expiration date; |expiry notice to be sent |however, |exactly 30 days before the |NotifyBorrowerDeparture |account expiration date; |would not begin showing an |- however, |alert on the patron account |NotifyBorrowerDeparture |until the next day. This |would not begin showing an |adjusts the timing on |alert on the patron account |NotifyBorrowerDeparture to |until the next day. |begin displaying the alert | |exactly the chosen number |This fixes the timing on |of days before the account |NotifyBorrowerDeparture so |expires. That way, if |that it begins displaying |MembershipExpiryDaysNotice |the alert exactly the |and NotifyBorrowerDeparture |chosen number of days |are set to the same value, |before the account expires. |they will both trigger on |That way, if |the same day. |MembershipExpiryDaysNotice | |and NotifyBorrowerDeparture | |are set to the same value, | |they will both trigger on | |the same day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 202426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202426&action=edit Bug 20573: Make NotifyBorrowerDeparture's date math consistent with MembershipExpiryDaysNotice To test: 1. Set both system preferences NotifyBorrowerDeparture and MembershipExpiryDaysNotice to 10 days 2. Create or edit a patron account with the following settings: - expiry date is exactly 10 days in the future - add an email address on the patron account - set messaging preferences to receive email notices for Patron account expiry 3. Run the membership expiry cron job to generate a notice: ktd --shell perl misc/cronjobs/membership_expiry.pl -c 4. Check notices tab on patron account --> A membership expiry notice has been queued for the patron 5. Click back to the patron details --> Note that there is no alert that the patron account will be expiring soon 6. Apply patch and restart_all 7. Refresh the patron details page --> You should now see an alert that the account will be expiring soon Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20573 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org