[Bug 10626] New: Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Bug ID: 10626 Summary: Remove doubled up TT plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm KohaBranchName.pm Branches.pm Also, it would be nice to add a usage example as documentation to the surviving plugins. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19866&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19866|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19867&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19869&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19869|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19870&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 19870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19870 Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Review of attachment 19870: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10626&attachment=19870) ----------------------------------------------------------------- ::: Koha/Template/Plugin/Branches.pm @@ +32,4 @@
my $sth = C4::Context->dbh->prepare($query); $sth->execute($branchcode); my $b = $sth->fetchrow_hashref(); + return $b ? encode( 'UTF-8', $b->{'branchname'} ) : q{};
By switching our templates to use this plugin, instead of KohaBranchName.pm we have changed the behaviour. We are now not using the GetBranchName subroutine, but instead doing a db query ourselves (which is probably better we shouldnt be using C4:: modules in the Koha:: space) but we are also doing this encode. And I am not convinced encode is what we should be doing here. Could you please explain why we are doing the encode? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- The use of encode is to make diacritics display correctly. This issue came up during the development of the Course Reserves ( Bug 10626 ) feature. You can see the patch where Paul added the encode to solve the issue here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18283&action=diff (In reply to Chris Cormack from comment #5)
Comment on attachment 19870 [details] [review] Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches
Review of attachment 19870 [details] [review]: -----------------------------------------------------------------
::: Koha/Template/Plugin/Branches.pm @@ +32,4 @@
my $sth = C4::Context->dbh->prepare($query); $sth->execute($branchcode); my $b = $sth->fetchrow_hashref(); + return $b ? encode( 'UTF-8', $b->{'branchname'} ) : q{};
By switching our templates to use this plugin, instead of KohaBranchName.pm we have changed the behaviour.
We are now not using the GetBranchName subroutine, but instead doing a db query ourselves (which is probably better we shouldnt be using C4:: modules in the Koha:: space) but we are also doing this encode.
And I am not convinced encode is what we should be doing here. Could you please explain why we are doing the encode?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19867|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20204&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19870|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20205&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle - view_holdsqueue.tt is still using 'USE KohaAuthorisedValues' - circulation.tt is still using 'USE KohaBranchName' after applying your patches. Could you add 2 follow ups please? Maybe we should also add a test to the QA script? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20659&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20660&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, Kyle, but one more for Authorised Values slipped in: /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/includes/item-status-schema-org.inc I am continueing with QA for KohaBranchName. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20205|0 |1 is obsolete| | Attachment #20660|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20846&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Also tested with a branch name with umlauts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20847&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: Make sure - independentbranches is turned on - Your user doesn't have superlibrarian permission Then - Try to check out an item with home and holding branch != logged in branch Patch works alright. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20204|0 |1 is obsolete| | Attachment #20659|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20848&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20849&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Trying to write my own test plan here: 1) AllowNotForLoanOverride = Allow Mark single item not for loan and try to check it out. Check item not for loan status shows up correctly in message: Item is normally not for loan (Staff Collection). Check out anyway? 2) Toggle AllowNotForLoanOverride = Not Allow Try to check out your not for loan item again. Message has changed, but not for loan status should still show: Item not for loan (Staff Collection). 3) Check out item that is marked damaged. Check damaged status shows correctly in list of checkouts. 4) Mark item as lost and check it out. Check lost status shows up correctly in message: This item has been lost with a status of "Lange überfällig (Verloren)". 5) Create your own custom SUGGEST_STATUS and check that it shows up correctly on the suggestion page. 6) Test item status show up correctly on OPAC detail page (lost, not for loan, damaged, etc). Requires follow-up patch to be applied. 7) Mark a suggestion with your custom status and make sure it shows up in the patron account in OPAC correctly. Passes tests and QA script - needs a follow up for item-status-schema-org.inc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20850&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9478 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20850|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20962&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8004 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20846|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22361&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Also tested with a branch name with umlauts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20847|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22363&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: Make sure - independentbranches is turned on - Your user doesn't have superlibrarian permission Then - Try to check out an item with home and holding branch != logged in branch Patch works alright. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22364&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20848|0 |1 is obsolete| | Attachment #20849|0 |1 is obsolete| | Attachment #20962|0 |1 is obsolete| | Attachment #22361|0 |1 is obsolete| | Attachment #22363|0 |1 is obsolete| | Attachment #22364|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22365&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Also tested with a branch name with umlauts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22366&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: Make sure - independentbranches is turned on - Your user doesn't have superlibrarian permission Then - Try to check out an item with home and holding branch != logged in branch Patch works alright. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22367&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22368&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Trying to write my own test plan here: 1) AllowNotForLoanOverride = Allow Mark single item not for loan and try to check it out. Check item not for loan status shows up correctly in message: Item is normally not for loan (Staff Collection). Check out anyway? 2) Toggle AllowNotForLoanOverride = Not Allow Try to check out your not for loan item again. Message has changed, but not for loan status should still show: Item not for loan (Staff Collection). 3) Check out item that is marked damaged. Check damaged status shows correctly in list of checkouts. 4) Mark item as lost and check it out. Check lost status shows up correctly in message: This item has been lost with a status of "Lange überfällig (Verloren)". 5) Create your own custom SUGGEST_STATUS and check that it shows up correctly on the suggestion page. 6) Test item status show up correctly on OPAC detail page (lost, not for loan, damaged, etc). Requires follow-up patch to be applied. 7) Mark a suggestion with your custom status and make sure it shows up in the patron account in OPAC correctly. Passes tests and QA script - needs a follow up for item-status-schema-org.inc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22369&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Rebased first patch to fix merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note - this is a bug, because the branches plugin to be removed breaks diacritics in branch names. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #29 from Galen Charlton <gmcharlt@gmail.com> --- I've pushed the two patches merging the branches plugins to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #30 from Galen Charlton <gmcharlt@gmail.com> --- The authorized value patches no longer apply, most likely the result of a conflict with the patch for bug 11322. Kyle, you have my bless to set the status back to passed QA once you've resolved the conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added a commit in the QA tests for that: commit 32dcd4db9639bb976763ad92759850bf96c2a59d Author: Jonathan Druart <jonathan.druart@biblibre.com> Date: Mon Dec 16 11:02:46 2013 +0100 TT plugins have been merged (see bug 10626) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22367|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23693&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22368|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23695&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Trying to write my own test plan here: 1) AllowNotForLoanOverride = Allow Mark single item not for loan and try to check it out. Check item not for loan status shows up correctly in message: Item is normally not for loan (Staff Collection). Check out anyway? 2) Toggle AllowNotForLoanOverride = Not Allow Try to check out your not for loan item again. Message has changed, but not for loan status should still show: Item not for loan (Staff Collection). 3) Check out item that is marked damaged. Check damaged status shows correctly in list of checkouts. 4) Mark item as lost and check it out. Check lost status shows up correctly in message: This item has been lost with a status of "Lange überfällig (Verloren)". 5) Create your own custom SUGGEST_STATUS and check that it shows up correctly on the suggestion page. 6) Test item status show up correctly on OPAC detail page (lost, not for loan, damaged, etc). Requires follow-up patch to be applied. 7) Mark a suggestion with your custom status and make sure it shows up in the patron account in OPAC correctly. Passes tests and QA script - needs a follow up for item-status-schema-org.inc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22369|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23696&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #35 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up updating the Bootstrap theme. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #36 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org