[Bug 10852] New: Add 3 filters to the serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Bug ID: 10852 Summary: Add 3 filters to the serials search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The serial module offers some filters to search serials. But 3 are missing: location, callnumber and expiration date. This feature will add them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20945&action=edit Bug 10852: serials search improvements This patch adds 3 filters for the serials search: - location - callnumber - expiration date To test: - Search serials by location and/or callnumber and/or expiration date and check that results are consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-25 last check this| | --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- It works well, but - I thought the filter on expiration date was checking the exact date. It seems that it getting subscriptions ending BEFORE the given date. Am I right? So, could you rephrase the name of the filter, so that it be obvious for users? - Search on Callnumber is not very precise. I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X" I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha. I'm waiting for your reaction, and for the moment, I keep the bug in Needs Signoff status. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #4)
So, could you rephrase the name of the filter, so that it be obvious for users?
I will submit a followup.
I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X" I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha.
I think it is an acceptable behavior, it is like it works in GetSubscriptions too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23294&action=edit Bug 10852: Rename the "expiration date" filter name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> ---
I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X" I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha.
I think it is an acceptable behavior, it is like it works in GetSubscriptions too.
OK. anyway it should not be a blocker for this enh. If someone wants to improve this behavior, he can do it later... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20945|0 |1 is obsolete| | --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23295&action=edit [PATCH][SIGNED OFF] Bug 10852: serials search improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23294|0 |1 is obsolete| | --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23296&action=edit [PATCH][SIGNED OFF] Bug 10852: Rename the "expiration date" filter name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23548&action=edit Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues Bug 10626 will remove the KohaAuthorisedValues plugin and keep the AuthorisedValues plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23549&action=edit Bug 10852: serials search improvements This patch adds 3 filters for the serials search: - location - callnumber - expiration date To test: - Search serials by location and/or callnumber and/or expiration date and check that results are consistent. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23550&action=edit Bug 10852: Rename the "expiration date" filter name Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23295|0 |1 is obsolete| | Attachment #23296|0 |1 is obsolete| | Attachment #23548|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23551&action=edit Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues Bug 10626 will remove the KohaAuthorisedValues plugin and keep the AuthorisedValues plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with some minor follow-ups. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org