[Bug 21531] New: Subscription "New fields" button should read "New field"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Bug ID: 21531 Summary: Subscription "New fields" button should read "New field" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 21519 Action buttons for any "New" operation use singular, so the "New fields" button on the "Add subscription fields" should read "New field." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21519 [Bug 21519] Switch two-column templates to Bootstrap grid: Serials part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80336&action=edit Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80336|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 80399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80399&action=edit Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80399|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80421&action=edit Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Bug 21531 depends on bug 21519, which changed state. Bug 21519 Summary: Switch two-column templates to Bootstrap grid: Serials part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21519 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer to avoid changing display of 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org