[Bug 21590] New: "send list" email uses the term "virtual shelf", this should be "list".
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Bug ID: 21590 Summary: "send list" email uses the term "virtual shelf", this should be "list". Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The text of an email sent via the OPAC 'send shelves' menu item reads "Hi, George sent you from our online catalog, the virtual shelf called ..." Per https://wiki.koha-community.org/wiki/Terminology, we should use 'list' instead of 'virtual shelf'. To re-create 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". This is hard coded in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 80754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80754&action=edit Bug 21174: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80754|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80806&action=edit Bug 21174: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called". https://bugs.koha-community.org/show_bug.cgi?id=21590 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 80850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80850&action=edit Bug 21590: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #80806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer to avoid string changes in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org