[Bug 27170] New: ILL availability should be able to display arbitrary links to related resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Bug ID: 27170 Summary: ILL availability should be able to display arbitrary links to related resources Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Currently, ILL availability uses the API response from the plugin to form a link if an item response contains a 'url' property. This is quite limiting. The EDS API, for example, can return multiple potential links to a resource. I am updating the EDS availability plugin to allow it to return an arbitrary number of links to a resource in a new 'links' property. This bug will add support for that property and will form links as appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 114256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114256&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: - Apply the bug - Enable ILL in Koha and install the FreeForm backend - Enable plugins - Install and configure the ILL EDS availability plugin version 1.0.7 (https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/tags/1.0.7) - Create an ILL request - TEST: On the availability screen, note that no links are displayed with the record title other than the link - Install and configure at least version 1.1.0 of the ILL EDS availability plugin (https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/latest) - Create an ILL request - TEST: On the availability screen, note that links are now displayed with the record title other than the link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: - Apply the bug - Enable ILL in Koha and install the FreeForm backend - Enable plugins - Install and configure the ILL EDS availability plugin version 1.0.7 (https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/tag/1.0.7) - Create an ILL request - TEST: On the availability screen, note that no links are displayed with the record title other than the link - Install and configure at least version 1.1.0 of the ILL EDS availability plugin (https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/latest) - Create an ILL request - TEST: On the availability screen, note that links are now displayed with the record title other than the link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|I18N/L10N |ILL --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Fixed bug component selection, I had mis-selected "I18n/L10N" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114256|0 |1 is obsolete| | --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122112&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122113&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122112|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122114&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122113|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122115&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122117&action=edit Bug 27170: Fix bug fix <sigh> This commit fixes the incorrect bug fix from the previous commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122114|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122167&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. Signed-off-by: Holly Cooper <hc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122115|0 |1 is obsolete| | --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122168&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. Signed-off-by: Holly Cooper <hc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122117|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 122169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122169&action=edit Bug 27170: Fix bug fix <sigh> This commit fixes the incorrect bug fix from the previous commit Signed-off-by: Holly Cooper <hc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122167|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122632&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122168|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122633&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122169|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122634&action=edit Bug 27170: Fix bug fix <sigh> This commit fixes the incorrect bug fix from the previous commit Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Additionally tested after an upgrade by Barry Cannon and a group of their customers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122632|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123339&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122633|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123340&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122634|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123341&action=edit Bug 27170: Fix bug fix <sigh> This commit fixes the incorrect bug fix from the previous commit Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Works well, returns EDS links when using the availability plugin Note: Enable ILLCheckAvailability to make this work :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org