[Bug 23096] New: Add floating toolbar to OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Bug ID: 23096 Summary: Add floating toolbar to OPAC lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 5287 Target Milestone: --- To match the updated OPAC search results page, the toolbar on the OPAC list contents table should be a floating toolbar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 [Bug 5287] Add floating toolbar to search results in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90512&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Patch doesn't apply. Unfortunately, the content toolbar doesn't stick to the top. No specific error message while applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This applies fine for me, so please re-test if you can. Note that it depends on Bug 5287 which requires that you rebuild the OPAC CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 90512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90512 Bug 23096: Add floating toolbar to OPAC lists Review of attachment 90512: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23096&attachment=90512) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc @@ +90,4 @@
</ul>
<!-- Dublin Core Modal Form --> +<div class="foo modal hide" id="exportModal_" tabindex="-1" role="dialog" aria-labelledby="exportModalLabel" aria-hidden="true">
foo seems out of place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Failing as per Owen's suggestion, since foo is out of place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90512|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90755&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90755|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90763&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- While it does scroll, there is a gap, that is distracting when things scroll through it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Rebuilding the OPAC CSS is part of the test plan for Bug 5287. That makes the patches work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90763|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90964&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Bug 23096 depends on bug 5287, which changed state. Bug 5287 Summary: Add floating toolbar to search results in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 5287 not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org