[Bug 23109] New: Incomplete description for staffacccess permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Bug ID: 23109 Summary: Incomplete description for staffacccess permission Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- On member-flags.pl, the descriptive text for the staffaccess permission reads "Allow staff members to modify permissions for other staff members." However, this permission also controls the ability to change the password of other staff members. I'd like to see it changed to read "Allow staff members to modify permissions and passwords for other staff members." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90706&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Version|18.11 |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90860&action=edit Bug 23109: (follow-up) fix typo in upgrade script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90706|0 |1 is obsolete| | Attachment #90860|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90861&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90862&action=edit Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90861|0 |1 is obsolete| | Attachment #90862|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90961&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90962&action=edit Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure we should care about the description in DB (as it is not used on the interface) but it will not hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Not pushed to 19.05.x Its minor and I prefer avoid db changes in stable branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org