[Bug 19551] New: Cash register report has bad erroneous results from wrong order of operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Bug ID: 19551 Summary: Cash register report has bad erroneous results from wrong order of operations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org in reports/cash_register_stats.pl $whereTType = q{ AND accounttype = 'FOR' OR accounttype = 'W' }; needs parens to combine the OR, better yet: $whereTType = q{ AND accounttype IN ('FOR','W') }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68857&action=edit Bug 19551 - Fix wrong order of operations iun cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Run the cash register report for current date, see your write off 4 - Run the cash register report for previous dates, still see your write off 5 - Apply patch 6 - Run cash register for current date, writee off shows (good) 7 - Run cash register report for previous dates, write off does not show (good) 8 - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6934 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 [Bug 6934] New report Cash Register Statistics -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68857|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68876&action=edit Bug 19551 - Fix wrong order of operations in cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Home -> Reports -> Cash register 4 - Fill in current date and transaction type 'Write off' 5 - Click Submit -- see your write off 6 - Fill in previous dates and transaction type 'Write off' 7 - Click Submit -- see your write off (bad) 8 - Apply patch 9 - Rerun steps 3-7 -- write only visible for current date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68876|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69371&action=edit Bug 19551 - Fix wrong order of operations in cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Home -> Reports -> Cash register 4 - Fill in current date and transaction type 'Write off' 5 - Click Submit -- see your write off 6 - Fill in previous dates and transaction type 'Write off' 7 - Click Submit -- see your write off (bad) 8 - Apply patch 9 - Rerun steps 3-7 -- write only visible for current date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Code has changed a lot because of Bug 19061 that is not in 17.05.x. If this is needed for 17.05.x, please provide a rebased patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org