[Bug 8904] New: Plack variable scoping in tools/overduerules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Priority: P5 - low Change sponsored?: --- Bug ID: 8904 Assignee: paul.poulain@biblibre.com Blocks: 7172 Summary: Plack variable scoping in tools/overduerules Severity: critical Classification: Unclassified OS: All Reporter: paul.poulain@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Tools Product: Koha It's impossible to save overduerules when you're running plack. Plack logs say: Variable "@rule_params" is not available at /home/paul/koha.dev/koha-community/tools/overduerules.pl line 44. Variable "$input" is not available at /home/paul/koha.dev/koha-community/tools/overduerules.pl line 52. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13185&action=edit Bug 5904 fix Plack scoping for overduerules.pl There are 2 Plack scoping errors in tools/overduerules.pl: the local sub blank_row require that @rule_params and input are global -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|critical |blocker --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Upgrading severity to BLO, because it's a blocker for Plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13185|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13198&action=edit Bug 8904: fix Plack scoping for overduerules.pl There are 2 Plack scoping errors in tools/overduerules.pl: the local sub blank_row require that @rule_params and input are global Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 13198 [details] Bug 8904: fix Plack scoping for overduerules.pl
There are 2 Plack scoping errors in tools/overduerules.pl: the local sub blank_row require that @rule_params and input are global
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
patch looks good and works as stated, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit dcf4a9b) * fa2cf71 Bug 8904: fix Plack scoping for overduerules.pl tools/overduerules.pl * tools/overduerules.pl OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8904 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org