[Bug 8636] New: Missing dependence on Cache::Memcached::Fast
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Priority: P5 - low Change sponsored?: --- Bug ID: 8636 Assignee: jcamins@cpbibliography.com Summary: Missing dependence on Cache::Memcached::Fast Severity: major Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11589&action=edit Bug 8636: Add missing dependencies Cache::Memcached::Fast is used for caching Test::YAML::Valid is used for tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing dependence on |Some dependencies are not |Cache::Memcached::Fast |listed by the installer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11589|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 11598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11598&action=edit [SIGNED-OFF] Bug 8636: Add missing dependencies Cache::Memcached::Fast is used for caching Test::YAML::Valid is used for tests Signed-off-by: Marc Veron <veron@veron.ch> Dependencies appear as expected... ...and I see that they are not instaled yet on my server :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, Are you sure we want Test::YAML::Valid as required? If it is just for tests, it seems it is optional. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #3)
Jared, Are you sure we want Test::YAML::Valid as required? If it is just for tests, it seems it is optional.
You are correct, it probably does not need to be required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11598|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11737&action=edit Bug 8636: Add missing dependencies Cache::Memcached::Fast is used for caching Test::YAML::Valid is used for tests Signed-off-by: Marc Veron <veron@veron.ch> Dependencies appear as expected... ...and I see that they are not instaled yet on my server :-) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, Could you confirm that the last patch is good for you ? Then I will mark it as passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #6)
Jared, Could you confirm that the last patch is good for you ? Then I will mark it as passed QA.
Looks good to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Add 2 not required missing dependencies: Cache::Memcached::Fast Test::YAML::Valid Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. (Not sure it's required for 3.8) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Half is, Test::YAML::Valid is needed in 3.8.x but not Cache::Memcached::Fast (3.8.4 use Cache::Memcached). Which reminds me, if 3.10 is switching we should remove that unneeded dependency. Ill rework this patch to just add the dependency on Test::YAML::Valid and push that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11883&action=edit [3.8.x] Bug 8636 missing dependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11737|0 |1 is obsolete| | Attachment #11883|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12765&action=edit Bug 8636: Add dependency on Test::Deep The test t/db_dependent/Koha.t uses Test::Deep to compare data structures, but that dependency was not listed for the installer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Before patch Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- AnyEvent 0 * 5.0 No AnyEvent::HTTP 0 * 2.13 No CHI 0 * 0.36 No CHI::Driver::Memcached 0 * 0.12 No Time::Progress 0 * 1.7 No -------------------------------------------------------------------------------------------- Total modules reported: 5 * Module is missing or requires an upgrade. After patch Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- AnyEvent 0 * 5.0 No AnyEvent::HTTP 0 * 2.13 No CHI 0 * 0.36 No CHI::Driver::Memcached 0 * 0.12 No Test::Deep 0 * 0.106 No Time::Progress 0 * 1.7 No -------------------------------------------------------------------------------------------- Total modules reported: 6 * Module is missing or requires an upgrade. Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12765|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12766&action=edit Bug 8636: Add dependency on Test::Deep The test t/db_dependent/Koha.t uses Test::Deep to compare data structures, but that dependency was not listed for the installer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12766|0 |1 is obsolete| | --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 12766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12766 Bug 8636: Add dependency on Test::Deep This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Fresh git install. Did the normal dselect steps. Made sure all the required items were installed. This left: $ ./koha_perl_deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- AnyEvent 0 * 5.0 No AnyEvent::HTTP 0 * 2.13 No Cache::Memcached::Fast 0 * 0.17 No DBD::Mock 0 * 1.39 No Data::Pagination 0 * 0.44 No Data::Paginator 0 * 0.04 No Test::Deep 0 * 0.106 No Test::Warn 0 * 0.21 No Test::YAML::Valid 0 * 0.04 No -------------------------------------------------------------------------------------------- Total modules reported: 9 * Module is missing or requires an upgrade. However, upon attempting to 'make test'. The tests failed because Cache::Memcached::Fast and DBD::Mock were not installed. Once installed the 'make test' passed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #18 from Robin Sheat <robin@catalyst.net.nz> --- Here's another one: # Failed test 'use Koha::SearchEngine;' # at t/00-load.t line 48. # Tried to use 'Koha::SearchEngine'. # Error: Can't locate Moose.pm in @INC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #19 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 13013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13013&action=edit Bug 8636 - add Moose dependency to the dependencies Koha::SearchEngine requires moose, but it wasn't declared as a dependency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #19)
Koha::SearchEngine requires moose, but it wasn't declared as a dependency.
Hi Robin, Currently Solr is optionnal. So I think Moose could be mark as not required. Moreover the patch adds some lines in debian/control. I think it would be a different patch, don't you think ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #21 from Robin Sheat <robin@catalyst.net.nz> --- Well, the tests don't pass without it, so if it's optional they will have to be fixed. The changes to debian/control are somewhat related to this. Basically it's the updated dependencies across the whole lot. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Without this being fixed packages can not be built from master. This plus bug 8890 and bug 3652 really really should be in master before the 3.10 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #21)
Well, the tests don't pass without it, so if it's optional they will have to be fixed. The changes to debian/control are somewhat related to this. Basically it's the updated dependencies across the whole lot.
I don't understand if you are waiting for something from me :) Setting the dependance as "not required" isn't the good way? Which test doesn't pass ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- I just did a fresh git install again under Ubuntu. Here's the output of my tests. libmoose-perl somehow got installed as part of the dselect, because I didn't expressly install it -- though, libmoosex-storage-perl and libmoosex-types-perl are in the install_misc/ubuntu.packages file used for the dselect. And they are not listed in the install_misc/debian.packages file. t/00-load.t ......................... 126/? # Failed test 'use Koha::Cache::Memcached;' Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' # at t/00-load.t line 47. # Tried to use 'Koha::Cache::Memcached'. # Error: Can't locate Cache/Memcached/Fast.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/mtompset/kohaclone/blib/PERL_MODULE_DIR/Koha/Cache/Memcached.pm line 23. # BEGIN failed--compilation aborted at /home/mtompset/kohaclone/blib/PERL_MODULE_DIR/Koha/Cache/Memcached.pm line 23. # Compilation failed in require at (eval 1319) line 2. # BEGIN failed--compilation aborted at (eval 1319) line 2. # Tests were run but no plan was declared and done_testing() was not seen. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' make: *** [test_dynamic] Error 255 t/Barcodes_ValueBuilder.t ........... 1/10 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 27) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/Barcodes_ValueBuilder.t line 15 t/Images.t .......................... 1/7 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 27) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/Images.t line 18 t/ItemType.t ........................ 1/15 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 27) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/ItemType.t line 19 t/Letters.t ......................... 1/2 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 989) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/Letters.t line 19 t/Matcher.t ......................... 1/10 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 27) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/Matcher.t line 18 t/Members_AttributeTypes.t .......... 1/9 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 27) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/Members_AttributeTypes.t line 18 t/SocialData.t ...................... 1/5 install_driver(Mock) failed: Can't locate DBD/Mock.pm in @INC (@INC contains: /home/mtompset/kohaclone/blib/PERL_MODULE_DIR /home/mtompset/kohaclone/blib/arch /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 959) line 3. Perhaps the DBD::Mock perl module hasn't been fully installed, or perhaps the capitalisation of 'Mock' isn't right. Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite2, Sponge, mysql. at t/SocialData.t line 18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major --- Comment #25 from Robin Sheat <robin@catalyst.net.nz> --- Sorry, I was answering yesterday from my phone, so wasn't as clear as I should have been. Anyway, we can make Moose optional, however it is needed for a "make test" to pass. I'm not sure what the preferred approach is here, but I can make it optional no problem. The packages will still pick it up in this case (long-term todo: have them put the optional ones into the "recommended" part of the debian/control file.) Will modify my patch to do this. mtompset: almost all your errors are due to missing libdbd-mock-perl, which is only needed for testing. Add that and most things should go away. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #26 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 13029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13029&action=edit Bug 8636 - add Moose dependency to the dependencies Koha::SearchEngine requires moose, but it wasn't declared as a dependency. Also update the debian/control dependencies to match the current state of the requirements. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #27 from Robin Sheat <robin@catalyst.net.nz> --- I think it was the 00-load test when it hit Koha::SearchEngine that failed, btw. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|major |critical --- Comment #28 from Robin Sheat <robin@catalyst.net.nz> --- FYI, the patch here is right now the only one remaining to allow the packages to build in a clean (pbuilder) environment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- I would like to test this patch but I don't know how. If I execute prove on the t directory, I get: "All tests successful." Moreover I think that 00-load.t does not take care of the Koha/SearchEngine directory (cf line 47: return if $m =~ /Koha::SearchEngine::/; # Koha::SearchEngine::* are experimental). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13029|0 |1 is obsolete| | --- Comment #30 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13164&action=edit Bug 8636 - add Moose dependency to the dependencies Koha::SearchEngine requires moose, but it wasn't declared as a dependency. Also update the debian/control dependencies to match the current state of the requirements. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #31 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Note, however, that the package dependencies for 3.10 are available for Squeeze only for i386 at this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #32 from Robin Sheat <robin@catalyst.net.nz> --- This only applies to XS packages, everything pure-perl ends up in the amd64 part as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #33 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #32)
This only applies to XS packages, everything pure-perl ends up in the amd64 part as well.
And we now have the one XS package for AMD64, too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #34 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #30)
Created attachment 13164 [details] Bug 8636 - add Moose dependency to the dependencies Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
patch looks good, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit ea9e867) * 4f83dd3 Bug 8636 - add Moose dependency to the dependencies C4/Installer/PerlDependencies.pm debian/control * C4/Installer/PerlDependencies.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #35 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and is suitable for backporting to 3.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13177&action=edit Bug 8636: add dependency on File::Slurp The command line scripts misc/migration_tools/koha-svc.pl and misc/load_testing/benchmark_webservices.pl require the File::Slurp Perl library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> --- Patch (adding Moose) pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #38 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org