[Bug 33002] New: 'Archive selected' button missing?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Bug ID: 33002 Summary: 'Archive selected' button missing? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 30599 added the ability to archive multiple purchase suggestions. The option is not there anymore...? To test: 1. Go to More > Suggestions 2. Click 'New purchase suggestion' 3. Enter a title 4. Click 'Submit your suggestion' --> Under the suggestions, there is a 'Delete selected' button/section. There should also be a 'Archive selected' button/section. The latter is not there anymore. See https://koha-community.org/manual/22.05/en/html/_images/suggestionmanagement... for reference in 22.05 I did a git grep "Archive selected" and didn't find anything... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599 [Bug 30599] Allow archiving multiple suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30599 |23991 Keywords| |regression See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30599 CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Git bisect: The button was accidentally removed by: Bug 23991: Move SearchSuggestion to Koha::Suggestions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599 [Bug 30599] Allow archiving multiple suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146908&action=edit Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146909&action=edit Bug 33003: Show the vendor type on vendor detail page When using an authorised value VENDOR_TYPE for the vendor type, we should show the AV description everywhere instead of the code. It already works on the vendor search, but not on the vendor detail page. With this patch it will also work there. To test: 1. Add at least one authorized value in VENDOR_TYPE 1.1. Go to Administration > Authorized values 1.2. Search for VENDOR_TYPE 1.3. Click 'Add' 1.4. Fill out the form - Authorized value: BOOK - Description: Print books 1.5. Click 'Save' 2. Add a new vendor 2.1. Go to Acquisitions 2.2. Click 'New vendor' 2.3. Fill out the form - Name: ABC Bookstore - Vendor type: Print books 2.4. Click 'Save' 3. Go to the vendor page 3.1. Click on the vendor name --> The value in "Type" is BOOK, it should be "Print books" 4. Apply patch 4.1. Repeat test, now it should show the description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146908|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146921&action=edit Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146921|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146959&action=edit Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Katrin! I really thought I was having eye trouble with this one... hehe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was definitely a little odd - rebase issue I guess. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- To RMs - please backport this to 22.11 since it's also broken there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146959|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147016&action=edit Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sorry about that! Thanks for the patch, Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
Sorry about that! Thanks for the patch, Katrin!
You are welcome. Doing a little detective work on the case of the "disappeared button" was fun :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #13 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 --- Comment #14 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Version(s)|23.05.00,22.11.04,22.11.04 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Missing depedencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org