[Bug 32653] New: Curbside pickups - wrong dates available at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Bug ID: 32653 Summary: Curbside pickups - wrong dates available at the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 [Bug 31262] Curbside pickups - disable dates without slots -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145362&action=edit Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis@univ-lyon3.fr Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145362|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145368&action=edit Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes for those that aren't familiar with using curbside pickups (using KTD): 1. Enable the CurbsidePickup system preference. 2. To configure curbside pickup for libraries, go to Administration > Patrons and circulation > Curbside pickup. 3. Select the tab and configure the libraries for this test (Centerville and Franklin): - Enable: toggle this so it is selected - Pickup interval: 5 - Maximum patrons per interval: 2 - Patron-scheduled pickup: toggle this so it is selected - For Curbside pickup hours: select the day and 'from' times as per the test plan (and enter an ending time, for example 08:12 to 20:00) - Click the 'Save configuration' button 4. Place a hold for a patron (I used koha) and then check an item in so that the hold is waiting for pickup (I used 39999000011418). 5. Log in to the OPAC (I used the koha user) and go to Your account > Curbside pickups > Schedule a pickup. 6. Select the library from the dropdown list, then click on the pickup date to see the calendar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145368|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147025&action=edit Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Version(s)|23.05.00,22.11.04,22.11.04 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org