[Bug 40222] New: Bootstrap popover components not updated for BS5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Bug ID: 40222 Summary: Bootstrap popover components not updated for BS5 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 The Bootstrap popover component uses data attributes for some of its features and those attributes' names changed in BS5. We need to update a few instances which were missed in the Bootstrap 5 upgrade. - data-content - data-trigger Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183424&action=edit Bug 40222: Bootstrap popover components not updated for BS5 This patch corrects a couple of templates which include a Bootstrap popover component, updating the data attributes which were missed during the BS5 upgrade. The patch also makes a minor change to CSS in order for the popover heading to not have unwanted margins. To test, apply the patch and rebuild the staff interface CSS. - Perform a catalog search in the staff interface. - Add one or more items to the cart. - Open the cart and hover your cursor over the "Items" heading. A popover should be triggered with a message about item sorting. - Go to Administration -> Circulation and Fine rules. - Edit a rule to add content to the "Note" field. - Save the rule and then hover your cursor over the "View note" text. The note you added should appear in a popover. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183424|0 |1 is obsolete| | --- Comment #2 from David Flater <flaterdavid@gmail.com> --- Created attachment 183514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183514&action=edit Bug 40222: Bootstrap popover components not updated for BS5 This patch corrects a couple of templates which include a Bootstrap popover component, updating the data attributes which were missed during the BS5 upgrade. The patch also makes a minor change to CSS in order for the popover heading to not have unwanted margins. To test, apply the patch and rebuild the staff interface CSS. - Perform a catalog search in the staff interface. - Add one or more items to the cart. - Open the cart and hover your cursor over the "Items" heading. A popover should be triggered with a message about item sorting. - Go to Administration -> Circulation and Fine rules. - Edit a rule to add content to the "Note" field. - Save the rule and then hover your cursor over the "View note" text. The note you added should appear in a popover. Sponsored-by: Athens County Public Libraries Signed-off-by: David Flater <flaterdavid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |flaterdavid@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183514|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184384&action=edit Bug 40222: Bootstrap popover components not updated for BS5 This patch corrects a couple of templates which include a Bootstrap popover component, updating the data attributes which were missed during the BS5 upgrade. The patch also makes a minor change to CSS in order for the popover heading to not have unwanted margins. To test, apply the patch and rebuild the staff interface CSS. - Perform a catalog search in the staff interface. - Add one or more items to the cart. - Open the cart and hover your cursor over the "Items" heading. A popover should be triggered with a message about item sorting. - Go to Administration -> Circulation and Fine rules. - Edit a rule to add content to the "Note" field. - Save the rule and then hover your cursor over the "View note" text. The note you added should appear in a popover. Sponsored-by: Athens County Public Libraries Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40222 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org