[Bug 40609] New: Invisible Button Styling in "hint" Container Until Hovered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Bug ID: 40609 Summary: Invisible Button Styling in "hint" Container Until Hovered Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Accessibility Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org Buttons styled with btn btn-light defaults and placed inside a .hint container are not visually distinguishable as interactive elements. They appear as plain text (black text on white background) with no border, background, or visual indicator of being a button. Only on hover do they become visible due to a grey background change. This leads to poor user experience, as users may not realize these are clickable buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 185178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185178&action=edit Bug 40609: Improve button visibility in .hint containers To test: 1. Go to Administration > Additional Parameters > Identity providers 2. Click on +New identity provider 3. Notice that the "Add default OAuth configuration" and "Add default OAuth mapping" buttons are not too visible. They just look like text unless they are hovered on. 4. Apply the patch, yarn build, restart all and clear the cache in your browser. 5. Refresh the page and view the buttons again. They now have a light grey background / border that makes them easier to identify as buttons. 6. Sign off and have a nice day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Instead of adding CSS could we change the button class from "btn-light" to "btn-default" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
Instead of adding CSS could we change the button class from "btn-light" to "btn-default" ?
Yea I can do that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 185218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185218&action=edit Bug 40609: Improve button visibility in Identity providers To test: 1. Go to Administration > Additional Parameters > Identity providers 2. Click on +New identity provider 3. Notice that the "Add default OAuth configuration" and "Add default OAuth mapping" buttons are not too visible. They just look like text unless they are hovered on. 4. Apply the patch, restart all 5. Refresh the page and view the buttons again. The button visibility has improved. 6. Sign off and have a nice day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185218|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185269&action=edit Bug 40609: Improve button visibility in Identity providers To test: 1. Go to Administration > Additional Parameters > Identity providers 2. Click on +New identity provider 3. Notice that the "Add default OAuth configuration" and "Add default OAuth mapping" buttons are not too visible. They just look like text unless they are hovered on. 4. Apply the patch, restart all 5. Refresh the page and view the buttons again. The button visibility has improved. 6. Sign off and have a nice day! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Thanks Laura! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185269|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185893&action=edit Bug 40609: Improve button visibility in Identity providers To test: 1. Go to Administration > Additional Parameters > Identity providers 2. Click on +New identity provider 3. Notice that the "Add default OAuth configuration" and "Add default OAuth mapping" buttons are not too visible. They just look like text unless they are hovered on. 4. Apply the patch, restart all 5. Refresh the page and view the buttons again. The button visibility has improved. 6. Sign off and have a nice day! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40609 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org