[Bug 12532] New: Redirect guarantee email to guarantor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bug ID: 12532 Summary: Redirect guarantee email to guarantor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Our sponsor require an adjustment to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected: ODUE, HOLD, DUE, PREDUE, CHECKIN, CHECKOUT, RLIST, ACCTDETAILS Sponsor by: ville de victoriaville -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 29510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29510&action=edit Bug 12532 - Redirect guarantee email to guarantor email garantor Modified: C4/Letters.pm -- _send_message_by_email check guarantor C4/Members.pm -- GetNoticeEmailAddress return email guarantor Testing: 0) Enable EnhancedMessagingPreferences preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this change of behaviour needs to be optional and needs a bit more thought. Would it be desirable to only cc the guarantor if the guarantee has a real email address? Should an email address on the guarantee record be ignored or take precedence? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we won't get around a pref here as people have been using relationships in different ways. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #4 from simith.doliveira@inlibro.com --- Created attachment 30747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30747&action=edit Bug 12532 - Redirect guarantee email to guarantor All email message placed in message_queue table will be affected. Patch updated; system preference EnableRedirectGuaranteeEmail added to enable this feature. Testing: I Apply the patch II Run updatedatabase.pl 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- <h1>Something went wrong !</h1>Applying: Bug 12532 - Redirect guarantee email to guarantor Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Letters.pm Auto-merging C4/Members.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30747|0 |1 is obsolete| | --- Comment #6 from simith.doliveira@inlibro.com --- Created attachment 35313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35313&action=edit Bug 12532 - Redirect guarantee email to guarantor All email message placed in message_queue table will be affected. Patch updated; system preference EnableRedirectGuaranteeEmail added to enable this feature. Testing: I Apply the patch II Run updatedatabase.pl 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #7 from Jesse Maseto <jesse@bywatersolutions.com> --- Bug 12532 - Redirect guarantee email to guarantor 35313 - Bug 12532 - Redirect guarantee email to guarantor Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12532 - Redirect guarantee email to guarantor Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Members.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 12532 - Redirect guarantee email to guarantor When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12532---Redirect-guarantee-email-to-guarantor-BQ1gJr.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35313|0 |1 is obsolete| | --- Comment #8 from simith.doliveira@inlibro.com --- Created attachment 36752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36752&action=edit Bug 12532 - Redirect guarantee email to guarantor All email message placed in message_queue table will be affected. Patch updated; system preference EnableRedirectGuaranteeEmail added to enable this feature. Testing: I Apply the patch II Run updatedatabase.pl 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from simith.doliveira@inlibro.com --- conflit fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 36752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36752 Bug 12532 - Redirect guarantee email to guarantor Review of attachment 36752: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=36752) ----------------------------------------------------------------- ::: C4/Members.pm @@ +1562,5 @@
+ my $enableRedirectGuaranteeEmail = C4::Context->preference("EnableRedirectGuaranteeEmail"); + if (!$enableRedirectGuaranteeEmail){ + $borrowerNumberToSendEmail = $borrowernumber; + $guarantorid = undef; + }
This logic works, but it is not clear to the person who reads code. @@ +1574,5 @@
+ my $guarantor = C4::Members::GetMember( 'borrowernumber' => $guarantorid ); + if ( $guarantor ){ + $to_address = $guarantor->{ $which_address }; + } + }
Mixing which_address comparisons with guarantorid logic in the same if structure level is not good coding style in my opinion. ::: installer/data/mysql/sysprefs.sql @@ +116,4 @@
('EnableBorrowerFiles','0',NULL,'If enabled, allows librarians to upload and attach arbitrary files to a borrower record.','YesNo'), ('EnableOpacSearchHistory','1','YesNo','Enable or disable opac search history',''), ('EnableSearchHistory','0','','Enable or disable search history','YesNo'), +('EnableRedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'),
R comes before S. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- If you modify routines in C4 or Koha namespaces, you need to make sure there is test coverage for your changes. Failed to add tests to ./t/db_dependent/Members.t reflecting changes in C4::Members::GetNoticeEmailAddress. Failed to add tests to ./t/db_dependent/Letters.t reflecting changes in the C4::Letters::_send_message_by_email routine, which is called by SendQueuedMessages. These tests would need to include things like intentional failures based on specific system preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira@inlibro.co |maxime.beaulieu@inlibro.com |m | CC| |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36752|0 |1 is obsolete| | --- Comment #12 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39787&action=edit Bug 12532 - Redirect guarantee email to guarantor Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- I tried testing, patches applied and update ran fine but both tests failed and emails were not redirected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- (In reply to Nick Clemens from comment #13)
I tried testing, patches applied and update ran fine but both tests failed and emails were not redirected.
What tests failed exactly? (With the #) I too had the tests failing at first. For me the failure was caused by missing patron categories and branches. (db_dependent, indeed) I tried my test plan again. The .t ran fine and the emails were redirected properly. Please note the emails are redirected as they are sent, so you need to run the process_message_queue.pl cronjob. The to_address field in the database does not indicate if the email is redirected or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39787|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 39925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39925&action=edit [SIGNED OFF] Bug 12532 - Redirect guarantee email to guarantor Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #16 from Nick Clemens <nick@quecheelibrary.org> --- Retested, all works as expected, must have been an issue on my end. The only confusion I see here is in checking the Notices tab on a patron's account doesn't show where the message went. A library should know if they have this enabled, and should be able to figure out emails were redirected, but just makes me pause. Not a blocker but wanted to mention. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
I feel like this change of behaviour needs to be optional and needs a bit more thought.
Would it be desirable to only cc the guarantor if the guarantee has a real email address? Should an email address on the guarantee record be ignored or take precedence?
Could we get an answer on this comment please? I was writing the same question before reading back the older comments: Why don't you simply cc the guarantor? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #18 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- (In reply to Jonathan Druart from comment #17)
(In reply to Katrin Fischer from comment #2)
I feel like this change of behaviour needs to be optional and needs a bit more thought.
Would it be desirable to only cc the guarantor if the guarantee has a real email address? Should an email address on the guarantee record be ignored or take precedence?
Could we get an answer on this comment please? I was writing the same question before reading back the older comments: Why don't you simply cc the guarantor?
Yes, you can! ;^)
I feel like this change of behaviour needs to be optional and needs a bit more thought.
It is optinal now. There is new syspref to enable the redirection (EnableRedirectGuaranteeEmail)
Would it be desirable to only cc the guarantor if the guarantee has a real email address?
I agree it would have been another option that works. However, the requirement was to send guarantee's emails to the guarantor. Whether we cc the guarantor or send all guarantee's emails to the guarantor, the expected result is the same : the guarantor get the emails.
Should an email address on the guarantee record be ignored or take precedence?
For this development, the guarantee's emails are ignored. The sponsor use it this way and so far, didn't ask to improve it. It would be nice to make it more flexible but I think this improvement should be part of another feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- François, Ok it works for me. But, let me explain a thought :) Bug 12802 is on its way and will be in conflict with this development (because it changes the behavior of the pref AutoEmailPrimaryAddress and the subroutine GetNoticeEmailAddress). I am just wondering if the enh introduced by this bug 12532 could not be a new entry in the multivalued pref AutoEmailPrimaryAddresses. We could have email, emailpro, B_email and "guarantor" (or even "email guarantor", "emailpro guarantor", "B_email guarantor"). This way we could sent the notice to the patron and the guarantor, and fix the special case where the guarantor does not have an email but the guarantee has one. I am not forcing you to agree with me, it's just a thinking :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #20 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- (In reply to Jonathan Druart from comment #19)
François,
Ok it works for me. But, let me explain a thought :) Bug 12802 is on its way and will be in conflict with this development (because it changes the behavior of the pref AutoEmailPrimaryAddress and the subroutine GetNoticeEmailAddress). I am just wondering if the enh introduced by this bug 12532 could not be a new entry in the multivalued pref AutoEmailPrimaryAddresses. We could have email, emailpro, B_email and "guarantor" (or even "email guarantor", "emailpro guarantor", "B_email guarantor"). This way we could sent the notice to the patron and the guarantor, and fix the special case where the guarantor does not have an email but the guarantee has one.
I am not forcing you to agree with me, it's just a thinking :)
Indeed, the "guarantor" option could be added to the syspref. If you agree to add this feature to bug 12802, we can close this one and/or mark it as duplicate. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12802 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Maxime Beaulieu from comment #20)
Indeed, the "guarantor" option could be added to the syspref. If you agree to add this feature to bug 12802, we can close this one and/or mark it as duplicate.
As you can see on bug 12802, I am not in charge of this bug anymore. And I would be very surprised that it will be included. I have suggested that to help you to integrate this one, not to make 12802 much harder to integrate. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #22 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- We won't (In reply to Jonathan Druart from comment #21)
(In reply to Maxime Beaulieu from comment #20)
Indeed, the "guarantor" option could be added to the syspref. If you agree to add this feature to bug 12802, we can close this one and/or mark it as duplicate.
As you can see on bug 12802, I am not in charge of this bug anymore. And I would be very surprised that it will be included.
Then, we will stay focus on this patch. :) I change the status to "signed off" since it was by Nick Clemens (see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532#c15) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Francois Charbonnier from comment #22)
As you can see on bug 12802, I am not in charge of this bug anymore. And I would be very surprised that it will be included.
I have absolutely no idea why I have written this last sentence. I was not wanted to tell that the patches on bug 12802 won't be included/pushed into master. But certainly more that the new author/maintainer of bug 12802 won't write the changes I have proposed on comment 19. Sorry for the misunderstanding and please provide an answer. If the solution seems better to you, please provide a followup on top of bug 12802. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org