http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36442&action=edit Bug 13790 - Update Koha Schema -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13743 CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, Olli has another patch for this on bug 13743, also this doesn't seem to take into account the changes we made after testing on bug 9303. I am wondering about the auto_increment on old_issues and the renumbering of the old entries especially. Could you try and figure this out together? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36441|0 |1 is obsolete| | Attachment #36442|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37108&action=edit Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 13743 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9303 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9011 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6427 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37108|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37709&action=edit [SIGNED OFF] Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #9 from Nick Clemens <nick@quecheelibrary.org> --- I cleared a simple conflict in updatedatabase (or attempted at least) and tested and all worked as expected. Hope it was okay to clear and sign off in one step. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37710|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 38073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38073&action=edit Bug 13790 - Update Koha Schema Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Being somewhat strict now :) I have some hesitations about your db revision: It makes Koha::Database appear now in mysql/updatedatabase.pl. Well, it must be introduced one day. That is true, but maybe it needs a little bit more thought? The DBIx project is not moving so much these days.. The $schema should not be in a far-away if statement btw. Secondly, you combine the old way with $dbh from C4 with some DBIx statements. That does not look good to me. And what about these lines: + my $max_issue_id = $schema->resultset('Issue')->get_column('issue_id')->max(); + $max_issue_id ||= $schema->resultset('OldIssue')->get_column('issue_id')->max(); + $max_issue_id ||= 0; + $max_issue_id++; + $dbh->do(qq{ + ALTER TABLE issues AUTO_INCREMENT = $max_issue_id} That is somewhat strange. It will work, but you should just pick max from issues. If there are no records, you are ready. Otherwise +1. All by all, I recommend adjusting your patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38081|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38082&action=edit Bug 13790 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 38156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38156&action=edit Bug 13790 - Update Koha Schema Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 38158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38158&action=edit Bug 13790: [QA Follow-up] Relocation of db revision in updatedatabase The db rev lines should not be under the bug 13068 sandbox section. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #20 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Thinking about Katrin's comment on Bug 13743 regarding the AUTO_INCREMENT of old_issues. Isnt it a bit dangerous to have the old_issues.issue_id as AUTO_INCREMENT? This feature works as well without it, and prevents accidentally adding old_issues from hypothetical other sources without a issue_id known. When issues.issue_id and old_issues.issue_id get out of sync, that would cause serious and hard-to-see issues when old_issues-table is not populated on check-ins. Nobody should touch the old_issues -table from anywhere but the C4::Circulation::AddReturn(), but dropping the AUTO_INCREMENT will make it a bit harder. I don't think this issue is a blocker, but I would feel better. BTW. Separating issues and old_issues is really awkward, but I guess we need to just live with it. Thinking from a statistical point of view. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Kyle: Please adjust ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38182&action=edit Bug 13790 [QA Followup] - Disable auto increment on old_issues after pk values are created -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38155|0 |1 is obsolete| | Attachment #38156|0 |1 is obsolete| | Attachment #38157|0 |1 is obsolete| | Attachment #38158|0 |1 is obsolete| | Attachment #38184|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38349&action=edit Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38351&action=edit Bug 13790 - Update Koha Schema Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38353&action=edit Bug 13790: [QA Follow-up] Relocation of db revision in updatedatabase The db rev lines should not be under the bug 13068 sandbox section. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38351|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 38429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38429&action=edit The script we use to update the schema didn't like the checksum of the provided patch. So I obsolete it and regenerate properly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #34 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I have problem with this patch. When applied to our database it generates following errors: [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Multiple primary key defined at /srv/koha/installer/data/mysql/updatedatabase.pl line 10166. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Unknown column 'issue_id' in 'order clause' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10170. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::st execute failed: Unknown column 'me.issue_id' in 'field list' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1481. DBIx::Class::ResultSetColumn::max(): Unknown column 'me.issue_id' in 'field list' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10174 It seems that ALTER TABLE issues ADD issue_id INT( 11 ) NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST doesn't work because we already have itemnumber defined as primary key. Should we drop it before this alter table? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Same problem here. It seems that primary key was introduced by Bug 4002 (version 3.05.00.009 - d0c9592592c0bd6c529915a9fbc04476f9b52851), and it was removed *only from kohastructure.sql* by Bug 6716 (version 3.05.00.011 - 91b5a09c6cef398d9ad39ca1ced7d6569a87456b) So the problem will happen to those who started with Koha 3.4 or less. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, thx for investigating. I think we need to fix this prior to release. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14069 | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have filed a separate 'blocker' bug 14069. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #39)

I have filed a separate 'blocker' bug 14069.

Great job! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15462 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 [Bug 15462] Unable to renew books via circ/renew.pl -- You are receiving this mail because: You are watching all bug changes.