[Bug 42702] New: Acquisitions: Cancel order link on parcel.pl absorbs following HTML into href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Bug ID: 42702 Summary: Acquisitions: Cancel order link on parcel.pl absorbs following HTML into href Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: nugged@gmail.com Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org The pending orders table on parcel.pl builds a malformed "Cancel order" link. The generated href is not closed after the invoice_id value, so the link text and following HTML are appended to the href. Steps to reproduce: 1. In Acquisitions, create or use a closed basket with a pending order. 2. Receive a shipment for the vendor and open the invoice receive page. 3. Inspect the "Cancel order" link in the pending orders table. Expected result: The link is rendered as valid HTML: <a href="/cgi-bin/koha/acqui/cancelorder.pl?...&referrer=/cgi-bin/koha/acqui/parcel.pl?invoiceid=3">Cancel order</a> Actual result: The link text and following HTML are included in the href: <a href="/cgi-bin/koha/acqui/cancelorder.pl?...&referrer=/cgi-bin/koha/acqui/parcel.pl?invoiceid=3Cancel order</a>... Notes: This appears to be a regression from the Bug 41563 parcel.tt tidy follow-up. Bug 41848 and Bug 42603 fixed nearby variable-name issues, but this malformed href remains. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 --- Comment #1 from Andrii Nugged <nugged@gmail.com> --- Created attachment 199601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199601&action=edit Bug 42702: Fix malformed cancel links on parcel.pl The pending orders table builds the two cancel order links with the link text concatenated immediately after the invoice_id value. This leaves the href attribute unclosed and makes the browser absorb the link text and following escaped HTML into the href. Add the missing separator after invoice_id for both cancel link builders. Test plan: 1. Create a closed acquisition basket with a pending order. 2. Open an invoice receive page for the vendor. 3. Inspect the Cancel order link in the pending orders table. 4. Confirm the href ends after invoiceid and the link text is outside the href. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199608&action=edit Bug 42702: Fix malformed cancel links on parcel.pl The pending orders table builds the two cancel order links with the link text concatenated immediately after the invoice_id value. This leaves the href attribute unclosed and makes the browser absorb the link text and following escaped HTML into the href. Add the missing separator after invoice_id for both cancel link builders. Test plan: 1. Create a closed acquisition basket with a pending order. 2. Open an invoice receive page for the vendor. 3. Inspect the Cancel order link in the pending orders table. 4. Confirm the href ends after invoiceid and the link text is outside the href. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|normal |major CC| |jonathan.druart@gmail.com Keywords| |rel_26_05_candidate --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Oops, sorry about that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199614&action=edit Bug 42702: Fix malformed cancel links on parcel.pl The pending orders table builds the two cancel order links with the link text concatenated immediately after the invoice_id value. This leaves the href attribute unclosed and makes the browser absorb the link text and following escaped HTML into the href. Add the missing separator after invoice_id for both cancel link builders. Test plan: 1. Create a closed acquisition basket with a pending order. 2. Open an invoice receive page for the vendor. 3. Inspect the Cancel order link in the pending orders table. 4. Confirm the href ends after invoiceid and the link text is outside the href. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42702 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org