[Bug 41425] New: Log entries for merging patrons are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Bug ID: 41425 Summary: Log entries for merging patrons are untranslatable Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com Depends on: 22632 Koha/Patron.pm: . " has been merged into " We should never hardcode strings into .pm, they are not translatable. This should be solved on template level instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 [Bug 22632] Add logging of merged patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190954&action=edit Bug 41425: Log entries for merging patrons are untranslatable This patch changes the way information is logged during patron merges. Instead of building an English sentence to be stored in the log now it stores JSON containing information about the patron record and the record which it is being merged with. To test, apply the patch and restart_services. - If necessary, go to Administration -> System preferences -> Logs and enable BorrowersLog. - Perform a patron search which will return more than one result. - Check the box next to two or more results and click "Merge selected patrons" in the toolbar. - Select one of the patron records to be merged with and click "Merge patrons." - Go to Tools -> Log viewer and perform a search limited to the patron module with "Display from" and "Display to" set to today. - You should see an entry for the patron merge you performed, with the updated patron linked in the "Object" column and information about the merge in the "Info" column, e.g. "John Smith (12345) merged with John Smith (45678). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190954|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191013&action=edit Bug 41425: Log entries for merging patrons are untranslatable This patch changes the way information is logged during patron merges. Instead of building an English sentence to be stored in the log now it stores JSON containing information about the patron record and the record which it is being merged with. To test, apply the patch and restart_services. - If necessary, go to Administration -> System preferences -> Logs and enable BorrowersLog. - Perform a patron search which will return more than one result. - Check the box next to two or more results and click "Merge selected patrons" in the toolbar. - Select one of the patron records to be merged with and click "Merge patrons." - Go to Tools -> Log viewer and perform a search limited to the patron module with "Display from" and "Display to" set to today. - You should see an entry for the patron merge you performed, with the updated patron linked in the "Object" column and information about the merge in the "Info" column, e.g. "John Smith (12345) merged with John Smith (45678). Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, but I noted that any previous patron merges now don't have any meaningful information in info column: 1. Patron merges after the patch display fine. Example: "Edna Acosta (5)" (linked to patron record) in object column, "Jordan Alford (23529000050113) merged into Edna Acosta (23529001000463)" in the info column. 2. Patron merges made before the patch now show as empty. Example: "Bob Singleton (38)" (linked to patron record) in object column, "() merged into ()" in the info column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191013|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192127&action=edit Bug 41425: Log entries for merging patrons are untranslatable This patch changes the way information is logged during patron merges. Instead of building an English sentence to be stored in the log now it stores JSON containing information about the patron record and the record which it is being merged with. To test, apply the patch and restart_services. - If necessary, go to Administration -> System preferences -> Logs and enable BorrowersLog. - Perform a patron search which will return more than one result. - Check the box next to two or more results and click "Merge selected patrons" in the toolbar. - Select one of the patron records to be merged with and click "Merge patrons." - Go to Tools -> Log viewer and perform a search limited to the patron module with "Display from" and "Display to" set to today. - You should see an entry for the patron merge you performed, with the updated patron linked in the "Object" column and information about the merge in the "Info" column, e.g. "John Smith (12345) merged with John Smith (45678). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from David Nind <david@davidnind.com> --- Changed to Failed QA as the Info message is "() merged into ()", before it was, for example: "Bob Singleton (23529000695412) has been merged into Bobbie Middleton (23529000080862)". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192127|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192474&action=edit Bug 41425: Log entries for merging patrons are untranslatable This patch changes the way information is logged during patron merges. Instead of building an English sentence to be stored in the log now it stores JSON containing information about the patron record and the record which it is being merged with. To test, apply the patch and restart_services. - If necessary, go to Administration -> System preferences -> Logs and enable BorrowersLog. - Perform a patron search which will return more than one result. - Check the box next to two or more results and click "Merge selected patrons" in the toolbar. - Select one of the patron records to be merged with and click "Merge patrons." - Go to Tools -> Log viewer and perform a search limited to the patron module with "Display from" and "Display to" set to today. - You should see an entry for the patron merge you performed, with the updated patron linked in the "Object" column and information about the merge in the "Info" column, e.g. "John Smith (12345) merged with John Smith (45678). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #5)
Changed to Failed QA as the Info message is "() merged into ()"
I've modified the patch to account for log messages which were previously saved as well as new messages which are stored differently. Previously saved log messages will still be untranslated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 192503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192503&action=edit Bug 41425: Log entries for merging patrons are untranslatable This patch changes the way information is logged during patron merges. Instead of building an English sentence to be stored in the log now it stores JSON containing information about the patron record and the record which it is being merged with. To test, apply the patch and restart_services. - If necessary, go to Administration -> System preferences -> Logs and enable BorrowersLog. - Perform a patron search which will return more than one result. - Check the box next to two or more results and click "Merge selected patrons" in the toolbar. - Select one of the patron records to be merged with and click "Merge patrons." - Go to Tools -> Log viewer and perform a search limited to the patron module with "Display from" and "Display to" set to today. - You should see an entry for the patron merge you performed, with the updated patron linked in the "Object" column and information about the merge in the "Info" column, e.g. "John Smith (12345) merged with John Smith (45678). Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This changes the way release notes| |information is logged | |during patron merges. | |Instead of building an | |English sentence to store | |in the log (example: Bob | |Singleton (23529000695412) | |has been merged into Bobbie | |Middleton | |(23529000080862)), it now | |stores JSON containing | |information about the | |patron record and the | |record which it is being | |merged with (example: Edna | |Acosta (23529001000463) | |merged into Jordan Alford | |(23529000050113)). The JSON | |information is accessible | |using reports. --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #7)
(In reply to David Nind from comment #5)
Changed to Failed QA as the Info message is "() merged into ()"
I've modified the patch to account for log messages which were previously saved as well as new messages which are stored differently. Previously saved log messages will still be untranslated.
Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- On ktd, merging 2 patrons, I get : " Merge failed! The following error was reported: {UNKNOWN}: Use of inherited AUTOLOAD for non-method Koha::Patron::to_json() is no longer allowed at /kohadevbox/koha/Koha/Patron.pm line 777. at /kohadevbox/koha/Koha/Patron.pm line 792 . " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org