[Bug 42020] New: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Bug ID: 42020 Summary: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org Prior to Bug 39482 a link to library info modal (with (i) icon) was generated only if OpacLibraryInfo was defined. Now it is there even if there is no OpacLibraryInfo at all and no URL defined for the library. It is generated in any circumstances. (BTW this makes the following snippet from opac-detail.tt dead: [% ELSIF holding_library_url %] <a href="[% holding_library_url | url %]"> [% holding_library_name | html %] </a> [% ELSE %] <span>[% holding_library_name | html %]</span> [% END %] ) This is because Koha::Library::opac_info returns a RS now, and not an object, as it was before. So a test on $item->holding_branch->opac_info( { lang => $lang } ) in opac-detail.pl returns always true. To reproduce: 1) Have a standard ktd installation. 2) Make sure there is no OpacLibraryInfo defined in HTML customizations. 3) Make sure there is no URL for any library. 4) In OPAC, perform any search. On a detail page you would see a link to an empty modal from the Current library items column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194935&action=edit Bug 42020: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL Prior to Bug 39482 a link to library info modal (with (i) icon) was generated only if OpacLibraryInfo was defined (cf. original Bug 29616). Now it is there even if there is no OpacLibraryInfo at all and no URL defined for the library. It is generated in any circumstances. The test on $item->holding_branch->opac_info( { lang => $lang } ) in opac-detail.pl now returns always true. This is because Koha::Library::opac_info returns a RS now, and not an object, as it was before (find_best_match --> search_for_display). This patch restores the original behavior designed in Bug 29616. Test plan: 1. Have a standard ktd installation. 2. Make sure there is no OpacLibraryInfo defined in HTML customizations. 3. Make sure there is no URL for any library. 4. In OPAC, perform any search. On a detail page you would see a link to an empty modal from the Current library items column. 5. Apply the patch ; restart_all. 6. Repeat p. 4. There should be no link generated now. 7. Extent the test to follow Bug 29616 logic: A. One with both branches.branchurl and OpacLibraryInfo defined B. One with branches.branchurl but no OpacLibraryInfo defined C. One with OpacLibraryInfo defined but no branches.branchurl D. One with neither branches.branchurl nor OpacLibraryInfo defined (neither for a specific library, nor default one) View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored CC| |oleonard@myacpl.org Comma delimited| |Pontificia Università di list of Sponsors| |San Tommaso d'Aquino | |(Angelicum) Assignee|oleonard@myacpl.org |januszop@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum) |(Angelicum), Pontificia | |Università di San Tommaso | |d'Aquino (Angelicum) Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194935|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 194937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194937&action=edit Bug 42020: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL Prior to Bug 39482 a link to library info modal (with (i) icon) was generated only if OpacLibraryInfo was defined (cf. original Bug 29616). Now it is there even if there is no OpacLibraryInfo at all and no URL defined for the library. It is generated in any circumstances. The test on $item->holding_branch->opac_info( { lang => $lang } ) in opac-detail.pl now returns always true. This is because Koha::Library::opac_info returns a RS now, and not an object, as it was before (find_best_match --> search_for_display). This patch restores the original behavior designed in Bug 29616. Test plan: 1. Have a standard ktd installation. 2. Make sure there is no OpacLibraryInfo defined in HTML customizations. 3. Make sure there is no URL for any library. 4. In OPAC, perform any search. On a detail page you would see a link to an empty modal from the Current library items column. 5. Apply the patch ; restart_all. 6. Repeat p. 4. There should be no link generated now. 7. Extent the test to follow Bug 29616 logic: A. One with both branches.branchurl and OpacLibraryInfo defined B. One with branches.branchurl but no OpacLibraryInfo defined C. One with OpacLibraryInfo defined but no branches.branchurl D. One with neither branches.branchurl nor OpacLibraryInfo defined (neither for a specific library, nor default one) View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the link to release notes| |library information (the | |(i) icon) in the OPAC | |holdings table, before the | |current and home library | |name. The (i) icon now only | |appears if the | |OpacLibraryInfo HTML | |customization is defined. | | | |Before this, a link to | |library information was | |appearing even if | |OpacLibraryInfo was not | |defined. | | | |(If there is: | |- only a URL defined for | |the library, the current | |and home library is an | |active link to the website | |- an OpacLibraryInfo HTML | |customization AND a URL | |defined for the library, an | |(i) icon is shown and in | |the pop-up window there is | |the library information and | |a button with "Visit | |website".) | | | |(This is related to bug | |39482 - Link to edit | |OpacLibraryInfo from | |library edit page broken, | |included in Koha 26.05.00 | |and 25.11.01.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 194938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194938&action=edit Bug 42020: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL Prior to Bug 39482 a link to library info modal (with (i) icon) was generated only if OpacLibraryInfo was defined (cf. original Bug 29616). Now it is there even if there is no OpacLibraryInfo at all and no URL defined for the library. It is generated in any circumstances. The test on $item->holding_branch->opac_info( { lang => $lang } ) in opac-detail.pl now returns always true. This is because Koha::Library::opac_info returns a RS now, and not an object, as it was before (find_best_match --> search_for_display). This patch restores the original behavior designed in Bug 29616. Test plan: 1. Have a standard ktd installation. 2. Make sure there is no OpacLibraryInfo defined in HTML customizations. 3. Make sure there is no URL for any library. 4. In OPAC, perform any search. On a detail page you would see a link to an empty modal from the Current library items column. 5. Apply the patch ; restart_all. 6. Repeat p. 4. There should be no link generated now. 7. Extent the test to follow Bug 29616 logic: A. One with both branches.branchurl and OpacLibraryInfo defined B. One with branches.branchurl but no OpacLibraryInfo defined C. One with OpacLibraryInfo defined but no branches.branchurl D. One with neither branches.branchurl nor OpacLibraryInfo defined (neither for a specific library, nor default one) View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: David Nind <david@davidnind.com> Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 194939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194939&action=edit Bug 42020: (follow-up) Fix spelling for button - web site to website Changes the spelling for the button in the pop-up window (when a library URL is defined) - "Visit web site" to "Visit website". The common spelling now is just website. Signed-off-by: David Nind <david@davidnind.com> Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194938|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195202&action=edit Bug 42020: (Bug 39482 follow-up) Library info link shown in OPAC without OpacLibraryInfo and library URL Prior to Bug 39482 a link to library info modal (with (i) icon) was generated only if OpacLibraryInfo was defined (cf. original Bug 29616). Now it is there even if there is no OpacLibraryInfo at all and no URL defined for the library. It is generated in any circumstances. The test on $item->holding_branch->opac_info( { lang => $lang } ) in opac-detail.pl now returns always true. This is because Koha::Library::opac_info returns a RS now, and not an object, as it was before (find_best_match --> search_for_display). This patch restores the original behavior designed in Bug 29616. Test plan: 1. Have a standard ktd installation. 2. Make sure there is no OpacLibraryInfo defined in HTML customizations. 3. Make sure there is no URL for any library. 4. In OPAC, perform any search. On a detail page you would see a link to an empty modal from the Current library items column. 5. Apply the patch ; restart_all. 6. Repeat p. 4. There should be no link generated now. 7. Extent the test to follow Bug 29616 logic: A. One with both branches.branchurl and OpacLibraryInfo defined B. One with branches.branchurl but no OpacLibraryInfo defined C. One with OpacLibraryInfo defined but no branches.branchurl D. One with neither branches.branchurl nor OpacLibraryInfo defined (neither for a specific library, nor default one) View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: David Nind <david@davidnind.com> Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194939|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195203&action=edit Bug 42020: (follow-up) Fix spelling for button - web site to website Changes the spelling for the button in the pop-up window (when a library URL is defined) - "Visit web site" to "Visit website". The common spelling now is just website. Signed-off-by: David Nind <david@davidnind.com> Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum), Pontificia |(Angelicum) |Università di San Tommaso | |d'Aquino (Angelicum) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org