[Bug 42467] New: Remove event attributes from MARC modification templates template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Bug ID: 42467 Summary: Remove event attributes from MARC modification templates template Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 38407 The MARC modification templates template has several "onChange" event attributes which should be moved to the corresponding JS file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198153&action=edit Bug 42467: Remove event attributes from MARC modification templates template This patch removes several "onChange" event attributes from marc_modification_templates.tt and moves the event handlers into marc_modification_templates.js. The patch also corrects a view minor zxlinting errors in the JS file. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> MARC modification templates. - Create a new template if necessary. - Click "New action." - Test the behavior of dropdowns and checkboxes in the new action form. - Fields should be correctly shown or hidden based on the selected actions - Fields should be correctly shown or hidden based on the "RegEx" checkbox. - Text the conditional dropdown along with the "matches" dropdown. - Test that the "matches" regex fields are correctly displayed according to the checkbox. - The browser developer console should show no "Content-Security-Policy" errors. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 198193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198193&action=edit Bug 42467: Remove event attributes from MARC modification templates template This patch removes several "onChange" event attributes from marc_modification_templates.tt and moves the event handlers into marc_modification_templates.js. The patch also corrects a view minor zxlinting errors in the JS file. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> MARC modification templates. - Create a new template if necessary. - Click "New action." - Test the behavior of dropdowns and checkboxes in the new action form. - Fields should be correctly shown or hidden based on the selected actions - Fields should be correctly shown or hidden based on the "RegEx" checkbox. - Text the conditional dropdown along with the "matches" dropdown. - Test that the "matches" regex fields are correctly displayed according to the checkbox. - The browser developer console should show no "Content-Security-Policy" errors. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198605&action=edit Bug 42467: Remove event attributes from MARC modification templates template This patch removes several "onChange" event attributes from marc_modification_templates.tt and moves the event handlers into marc_modification_templates.js. The patch also corrects a view minor zxlinting errors in the JS file. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> MARC modification templates. - Create a new template if necessary. - Click "New action." - Test the behavior of dropdowns and checkboxes in the new action form. - Fields should be correctly shown or hidden based on the selected actions - Fields should be correctly shown or hidden based on the "RegEx" checkbox. - Text the conditional dropdown along with the "matches" dropdown. - Test that the "matches" regex fields are correctly displayed according to the checkbox. - The browser developer console should show no "Content-Security-Policy" errors. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198606&action=edit Bug 42467: Init mmtas to an empty array Patch from commit c41d36b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org