[Bug 27406] New: Update intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt to adhere to ACC2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Bug ID: 27406 Summary: Update intranet-tmpl/prog/en/modules/admin/searchengine/elast icsearch/mappings.tt to adhere to ACC2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We need to update number type inputs on intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt to adhere to ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |catherinem2003@gmail.com |ity.org | CC| |catherinem2003@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 --- Comment #1 from Catherine <catherinem2003@gmail.com> --- Created attachment 115404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115404&action=edit Bug 27406: update file to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: ken the file and ensure that no other inputs of type="number were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115404|0 |1 is obsolete| | --- Comment #2 from Catherine <catherinem2003@gmail.com> --- Created attachment 115406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115406&action=edit Bug 27406: update file to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: open the file and ensure that no other inputs of type="number" were missed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115406|0 |1 is obsolete| | --- Comment #3 from Catherine <catherinem2003@gmail.com> --- Created attachment 115464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115464&action=edit Bug 27406: update file to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: open the file and ensure that no other inputs of type="number" were missed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115464|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115482&action=edit Bug 27406: update file to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: open the file and ensure that no other inputs of type="number" were missed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115521&action=edit Bug 27406: Update elasticsearch mapping to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: open the file and ensure that no other inputs of type="number" were missed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work Catherine, thanks. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Summary|Update |Update |intranet-tmpl/prog/en/modul |admin/searchengine/elastics |es/admin/searchengine/elast |earch/mappings.tt to adhere |icsearch/mappings.tt to |to ACC2 |adhere to ACC2 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose not to backport since there are several places still at work (children of Bug 26926). Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org