[Bug 27439] New: Improve hint labels on patron attribute type entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Bug ID: 27439 Summary: Improve hint labels on patron attribute type entry form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org There are some markup inconsistencies in admin/patron-attr-types.tt which should be cleaned up, and system preference references should be linked directly to the preference (with permission) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115182&action=edit Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115182|0 |1 is obsolete| | --- Comment #2 from Victoria Faafia <vfaafia29@gmail.com> --- Created attachment 115255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115255&action=edit Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. Signed-off-by: Victoria Faafia <vfaafia29@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115255|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115258&action=edit Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. Signed-off-by: Victoria Faafia <vfaafia29@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for testing, Victoria! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, shouldn't we remove the "Authorized value category;" part from "Authorized value category; if one is selected, the patron record input page will only allow values to be chosen from the authorized value list. However, an authorized value list is not enforced during batch patron import."? https://snipboard.io/u5vmDB.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115429&action=edit Bug 27439: Remove repetition in hint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27439 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org