[Bug 39325] New: Run codespell successfully on the whole codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Bug ID: 39325 Summary: Run codespell successfully on the whole codebase Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 39324 Codespell is run by the QA script, but we have a lot of typos. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39324 [Bug 39324] [OMNIBUS] All QA tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179269&action=edit Bug 39325: Automatic fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179270&action=edit Bug 39325: [DO NOT PUSH] script Script used to generate the "Automatic fix" patch. I don't think we need this script pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179271&action=edit Bug 39325: .codespell-ignore List of words to ignore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179272&action=edit Bug 39325: Add test We certainly want to improve this test and run it in parallel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Anybody willing to help here? We need to review the "Automatic fix" commit and: 1. Make sure the changes are correct 2. Adjust the "FIXME CODESPELL" occurrences 3. Add words to .codespell-ignore when needed Unfortunately we cannot use the "inline ignore" (yet) that is in 2.3.0 that will be available in trixie (we have 2.2.2 in bookworm). https://github.com/codespell-project/codespell/pull/2400 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39319, 39365, 39367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 [Bug 39319] xt/author/podcorrectness.t only test POD for perl files within C4 and Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 [Bug 39365] `perl -cw` should pass on all Perl files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39367 [Bug 39367] Add POD to all subroutines/methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179269|0 |1 is obsolete| | Attachment #179270|0 |1 is obsolete| | Attachment #179271|0 |1 is obsolete| | Attachment #179272|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179501&action=edit Bug 39325: [DO NOT PUSH] script Script used to generate the "Automatic fix" patch. I don't think we need this script pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179502&action=edit Bug 39325: .codespell-ignore List of words to ignore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179503&action=edit Bug 39325: Add test We certainly want to improve this test and run it in parallel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179504&action=edit Bug 39325: Automatic fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179505&action=edit Bug 39325: Manual fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179506&action=edit Bug 39325: manual - reserv => reserve because of automatic changes in circ/transferstoreceive.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179507&action=edit Bug 39325: manual - hilighted => highlighted All the other occurrences have been updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179508&action=edit Bug 39325: manual - suggestion - no one => no_one It has been changed (automatically) from "noone" to "no one", which was wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179509&action=edit Bug 39325: Adjust DB We need to adjust kohastructure.sql, sysprefs.sql and the DB itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179510&action=edit Bug 39325: Revert dbic schema files We need the md5sum to be adjusted. This should be done by the RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179511&action=edit Bug 39325: Tidy Some files need to be tidy after the automatic commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179512&action=edit Bug 39325: Exclude atomic update - TODO RM TODO: We will need to adjust this path with the db_rev one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Several "words" have been added to .codespell-ignore in order to make the codespell tests pass. In a next step we will want to use the inline ignore. See previous comment: """ Unfortunately we cannot use the "inline ignore" (yet) that is in 2.3.0 that will be available in trixie (we have 2.2.2 in bookworm). https://github.com/codespell-project/codespell/pull/2400 """ Some manual changes are a bit messy (installer/data/mysql/db_revs/220600059.pl) to trick codespell, but overall the automatic changes are correct and everything was easy to deal with. Test plan: 1. Apply the whole patchset, and the dependencies (if not pushed yet). There is a remote branch available in my gitlab repo, with everything applied: https://gitlab.com/joubu/Koha/-/commits/bug_39325 2. Squash the "Automatic fix" and the manual patches for easy review 3. Have a look at the generated commit and review every changes 4. Run `prove xt/author_codespell.t`. The only failures should be on Koha/Schema/Result files. 5. Run the updatedatabase script and confirm that the typos have been fixed in the DB (mostly in the COMMENTs) Bonus, test the new version of the QA script 6. inside ktd, go to /kohadevbox/qa-test-tools and checkout the dedicated branch # as root % git remote add joubu https://gitlab.com/joubu/qa-test-tools.git % git checkout joubu/issue_93 # as koha user, go to /kohadevbox/koha and run the qa script % qa RM note: You will need to adjust the patch "Bug 39325: Exclude atomic update - TODO RM": the atomicupdate path needs to be the one of the db_rev, so the tests will ignore the file as it contains typo on purpose. Also don't forget to regenerate the dbic schema files. Several "words" have been added to .codespell-ignore to make the codespell tests pass. In the next step, we will use inline ignores. See the previous comment: """ Unfortunately, we cannot use the "inline ignore" feature (yet), which was introduced in version 2.3.0 and will be available in Trixie (we currently have 2.2.2 in Bookworm). https://github.com/codespell-project/codespell/pull/2400 """" Some manual changes are a bit messy (e.g., installer/data/mysql/db_revs/220600059.pl) as a workaround for codespell, but overall, the automatic changes are correct and easy to handle. Test Plan: 1. Apply the entire patch set, along with its dependencies (if they haven't been pushed yet). A remote branch with everything applied is available in my GitLab repo: https://gitlab.com/joubu/Koha/-/commits/bug_39325 2. Squash the "Automatic fix" and manual patches for easier review. 3. Review the generated commit and verify all changes. 4.Run prove xt/author_codespell.t. The only expected failures should be in Koha/Schema/Result files. 5.Run the updatedatabase script and confirm that the typos have been fixed in the database (mostly in the COMMENT fields). Bonus: 6. Test the new version of the QA script Inside ktd, navigate to /kohadevbox/qa-test-tools and check out the dedicated branch: # As root: % git remote add joubu https://gitlab.com/joubu/qa-test-tools.git % git checkout joubu/issue_93 # As the koha user, navigate to /kohadevbox/koha and run the QA script: % qa RM Note: You will need to adjust the patch "Bug 39325: Exclude atomic update - TODO RM". The atomicupdate path must match the corresponding db_rev, so the tests correctly ignore the file (as it contains intentional typos). Also, don’t forget to regenerate the DBIC schema files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Several "words" have been added to .codespell-ignore to make the codespell tests pass. In the next step, we will use inline ignores. See the previous comment: """ Unfortunately, we cannot use the "inline ignore" feature (yet), which was introduced in version 2.3.0 and will be available in Trixie (we currently have 2.2.2 in Bookworm). https://github.com/codespell-project/codespell/pull/2400 """" Some manual changes are a bit messy (e.g., installer/data/mysql/db_revs/220600059.pl) as a workaround for codespell, but overall, the automatic changes are correct and easy to handle. Test Plan: 1. Apply the entire patch set, along with its dependencies (if they haven't been pushed yet). A remote branch with everything applied is available in my GitLab repo: https://gitlab.com/joubu/Koha/-/commits/bug_39325 2. Squash the "Automatic fix" and manual patches for easier review. 3. Review the generated commit and verify all changes. 4.Run prove xt/author_codespell.t. The only expected failures should be in Koha/Schema/Result files. 5.Run the updatedatabase script and confirm that the typos have been fixed in the database (mostly in the COMMENT fields). Bonus: 6. Test the new version of the QA script Inside ktd, navigate to /kohadevbox/qa-test-tools and check out the dedicated branch: # As root: % git remote add joubu https://gitlab.com/joubu/qa-test-tools.git % git checkout joubu/issue_93 # As the koha user, navigate to /kohadevbox/koha and run the QA script: % qa RM Note: You will need to adjust the patch "Bug 39325: Exclude atomic update - TODO RM". The atomicupdate path must match the corresponding db_rev, so the tests correctly ignore the file (as it contains intentional typos). Also, don’t forget to regenerate the DBIC schema files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179501|0 |1 is obsolete| | Attachment #179502|0 |1 is obsolete| | Attachment #179503|0 |1 is obsolete| | Attachment #179504|0 |1 is obsolete| | Attachment #179505|0 |1 is obsolete| | Attachment #179506|0 |1 is obsolete| | Attachment #179507|0 |1 is obsolete| | Attachment #179508|0 |1 is obsolete| | Attachment #179509|0 |1 is obsolete| | Attachment #179510|0 |1 is obsolete| | Attachment #179511|0 |1 is obsolete| | Attachment #179512|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179517&action=edit Bug 39325: [DO NOT PUSH] script Script used to generate the "Automatic fix" patch. I don't think we need this script pushed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179518&action=edit Bug 39325: .codespell-ignore List of words to ignore Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179519&action=edit Bug 39325: Add test We certainly want to improve this test and run it in parallel. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179522&action=edit Bug 39325: Automatic fix Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179525&action=edit Bug 39325: Manual fixes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179527&action=edit Bug 39325: manual - reserv => reserve because of automatic changes in circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179528&action=edit Bug 39325: manual - hilighted => highlighted All the other occurrences have been updated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179529&action=edit Bug 39325: manual - suggestion - no one => no_one It has been changed (automatically) from "noone" to "no one", which was wrong. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179530&action=edit Bug 39325: Adjust DB We need to adjust kohastructure.sql, sysprefs.sql and the DB itself. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179531&action=edit Bug 39325: Revert dbic schema files We need the md5sum to be adjusted. This should be done by the RM. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179532&action=edit Bug 39325: Tidy Some files need to be tidy after the automatic commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179533&action=edit Bug 39325: Exclude atomic update - TODO RM TODO: We will need to adjust this path with the db_rev one Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179534&action=edit Bug 39325: (follow-up) A few minor corrections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 39458 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179517|0 |1 is obsolete| | --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180137&action=edit Bug 39325: [DO NOT PUSH] script Script used to generate the "Automatic fix" patch. I don't think we need this script pushed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179518|0 |1 is obsolete| | --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180138&action=edit Bug 39325: .codespell-ignore List of words to ignore Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179519|0 |1 is obsolete| | --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180139&action=edit Bug 39325: Add test We certainly want to improve this test and run it in parallel. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179522|0 |1 is obsolete| | --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180140&action=edit Bug 39325: Automatic fix Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179525|0 |1 is obsolete| | --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180141&action=edit Bug 39325: Manual fixes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179527|0 |1 is obsolete| | --- Comment #39 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180142&action=edit Bug 39325: manual - reserv => reserve because of automatic changes in circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179528|0 |1 is obsolete| | --- Comment #40 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180143&action=edit Bug 39325: manual - hilighted => highlighted All the other occurrences have been updated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179529|0 |1 is obsolete| | --- Comment #41 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180144&action=edit Bug 39325: manual - suggestion - no one => no_one It has been changed (automatically) from "noone" to "no one", which was wrong. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179530|0 |1 is obsolete| | --- Comment #42 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180145&action=edit Bug 39325: Adjust DB We need to adjust kohastructure.sql, sysprefs.sql and the DB itself. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179531|0 |1 is obsolete| | --- Comment #43 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180146&action=edit Bug 39325: Revert dbic schema files We need the md5sum to be adjusted. This should be done by the RM. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179532|0 |1 is obsolete| | --- Comment #44 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180147&action=edit Bug 39325: Tidy Some files need to be tidy after the automatic commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179533|0 |1 is obsolete| | --- Comment #45 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180148&action=edit Bug 39325: Exclude atomic update - TODO RM TODO: We will need to adjust this path with the db_rev one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179534|0 |1 is obsolete| | --- Comment #46 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180149&action=edit Bug 39325: (follow-up) A few minor corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #47 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180150&action=edit Bug 39325: (QA follow-up) Adjust some issues connexion is a product, added to ignore file tablee -> tables a few other small corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39325: [DO NOT PUSH] script Applying: Bug 39325: .codespell-ignore Applying: Bug 39325: Add test Applying: Bug 39325: Automatic fix .git/rebase-apply/patch:585: trailing whitespace. C<$needsconfirmation> a reference to a hash. It contains reasons why the loan .git/rebase-apply/patch:882: trailing whitespace. selects which template to use, either the opac or the intranet .git/rebase-apply/patch:2515: trailing whitespace. =cut .git/rebase-apply/patch:3756: trailing whitespace. =item cloud-kw.pl [--verbose|--help] --conf=F<cloud.conf> error: sha1 information is lacking or useless (C4/Languages.pm). error: could not build fake ancestor Patch failed at 0001 Bug 39325: Automatic fix hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-39325-Automatic-fix-_xnhnnpe.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180137|0 |1 is obsolete| | Attachment #180138|0 |1 is obsolete| | Attachment #180139|0 |1 is obsolete| | Attachment #180140|0 |1 is obsolete| | Attachment #180141|0 |1 is obsolete| | Attachment #180142|0 |1 is obsolete| | Attachment #180143|0 |1 is obsolete| | Attachment #180144|0 |1 is obsolete| | Attachment #180145|0 |1 is obsolete| | Attachment #180146|0 |1 is obsolete| | Attachment #180147|0 |1 is obsolete| | Attachment #180148|0 |1 is obsolete| | Attachment #180149|0 |1 is obsolete| | Attachment #180150|0 |1 is obsolete| | --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181510&action=edit Bug 39325: [DO NOT PUSH] script Script used to generate the "Automatic fix" patch. I don't think we need this script pushed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181511&action=edit Bug 39325: .codespell-ignore List of words to ignore Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181512&action=edit Bug 39325: Add test We certainly want to improve this test and run it in parallel. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181513&action=edit Bug 39325: Automatic fix Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181514&action=edit Bug 39325: Manual fixes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181515&action=edit Bug 39325: manual - reserv => reserve because of automatic changes in circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181516&action=edit Bug 39325: manual - hilighted => highlighted All the other occurrences have been updated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181517&action=edit Bug 39325: manual - suggestion - no one => no_one It has been changed (automatically) from "noone" to "no one", which was wrong. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181518&action=edit Bug 39325: Adjust DB We need to adjust kohastructure.sql, sysprefs.sql and the DB itself. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181519&action=edit Bug 39325: Revert dbic schema files We need the md5sum to be adjusted. This should be done by the RM. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #59 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181520&action=edit Bug 39325: Tidy Some files need to be tidy after the automatic commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181521&action=edit Bug 39325: Exclude atomic update - TODO RM TODO: We will need to adjust this path with the db_rev one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #61 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181522&action=edit Bug 39325: (follow-up) A few minor corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181523&action=edit Bug 39325: (QA follow-up) Adjust some issues connexion is a product, added to ignore file tablee -> tables a few other small corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I already got a conflict again :( Can you please also check: I tried to leave off the first DO NOT PUSH patch (git bz apply -i), but then I also get a conflict, so I think some later patch also touches it... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39325: [DO NOT PUSH] script Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 39325: .codespell-ignore Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 39325: Add test Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 39325: Automatic fix .git/rebase-apply/patch:585: trailing whitespace. C<$needsconfirmation> a reference to a hash. It contains reasons why the loan .git/rebase-apply/patch:882: trailing whitespace. selects which template to use, either the opac or the intranet .git/rebase-apply/patch:2515: trailing whitespace. =cut .git/rebase-apply/patch:3763: trailing whitespace. =item cloud-kw.pl [--verbose|--help] --conf=F<cloud.conf> warning: 4 lines add whitespace errors. Using index info to reconstruct a base tree... M Makefile.PL M koha-tmpl/opac-tmpl/bootstrap/js/datatables.js .git/rebase-apply/patch:585: trailing whitespace. C<$needsconfirmation> a reference to a hash. It contains reasons why the loan .git/rebase-apply/patch:882: trailing whitespace. selects which template to use, either the opac or the intranet .git/rebase-apply/patch:2515: trailing whitespace. =cut .git/rebase-apply/patch:3763: trailing whitespace. =item cloud-kw.pl [--verbose|--help] --conf=F<cloud.conf> warning: 4 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js Auto-merging Makefile.PL error: Failed to merge in the changes. Patch failed at 0001 Bug 39325: Automatic fix hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-39325-Automatic-fix-c49605tp.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181510|0 |1 is obsolete| | Attachment #181513|0 |1 is obsolete| | Attachment #181514|0 |1 is obsolete| | Attachment #181515|0 |1 is obsolete| | Attachment #181516|0 |1 is obsolete| | Attachment #181517|0 |1 is obsolete| | Attachment #181518|0 |1 is obsolete| | Attachment #181519|0 |1 is obsolete| | Attachment #181520|0 |1 is obsolete| | Attachment #181521|0 |1 is obsolete| | Attachment #181522|0 |1 is obsolete| | Attachment #181523|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181611&action=edit Bug 39325: Automatic fix Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181612&action=edit Bug 39325: Manual fixes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181613&action=edit Bug 39325: manual - reserv => reserve because of automatic changes in circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #67 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181614&action=edit Bug 39325: manual - hilighted => highlighted All the other occurrences have been updated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #68 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181615&action=edit Bug 39325: manual - suggestion - no one => no_one It has been changed (automatically) from "noone" to "no one", which was wrong. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #69 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181616&action=edit Bug 39325: Adjust DB We need to adjust kohastructure.sql, sysprefs.sql and the DB itself. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #70 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181617&action=edit Bug 39325: Revert dbic schema files We need the md5sum to be adjusted. This should be done by the RM. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181618&action=edit Bug 39325: Tidy Some files need to be tidy after the automatic commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #72 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181619&action=edit Bug 39325: Exclude atomic update - TODO RM TODO: We will need to adjust this path with the db_rev one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #73 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181620&action=edit Bug 39325: (follow-up) A few minor corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #74 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181621&action=edit Bug 39325: (QA follow-up) Adjust some issues connexion is a product, added to ignore file tablee -> tables a few other small corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- * Fixed file permission (+x) on codespell.t * Added a success message to the db update * Tidied fix-perl-path.PL * Moved database update * Adjusted path in Bug 39325: Exclude atomic update - TODO RM * Ran dbic after updatedatabase and comitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #77 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181637&action=edit Bug 39325: (follow-up) Adjust DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #78 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #77)
Created attachment 181637 [details] [review] Bug 39325: (follow-up) Adjust DB
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #79 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181651&action=edit Bug 39325: Fix t/Makefile.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #81 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181983&action=edit Bug 39325: Skip codespell check for bullseye bullseye has 2.0.0-1 bookworm has 2.2.2-1 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up "Skip codespell..." pushed to main (soon) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 [Bug 39874] Template error prevents authority merging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #83 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Bug 39325 depends on bug 39319, which changed state. Bug 39319 Summary: xt/author/podcorrectness.t only test POD for perl files within C4 and Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #84 from David Nind <david@davidnind.com> --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Bug 39325 depends on bug 39365, which changed state. Bug 39365 Summary: `perl -cw` should pass on all Perl files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 Bug 39325 depends on bug 39367, which changed state. Bug 39367 Summary: Add POD to all subroutines/methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39367 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org