[Bug 39368] New: Warnings from t::lib::Mocks::Zebra because of statement after exec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Bug ID: 39368 Summary: Warnings from t::lib::Mocks::Zebra because of statement after exec Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 exec will replace the current process, it does not make sense to have another statement after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179454&action=edit Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179454|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180086&action=edit Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested on top of bug 39367. Patch makes the mentioned tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180086|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180238&action=edit Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested on top of bug 39367. Patch makes the mentioned tests pass. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |39367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39367 [Bug 39367] Add POD to all subroutines/methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- No xt/author/pod_coverage.t in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39368 Bug 39368 depends on bug 39367, which changed state. Bug 39367 Summary: Add POD to all subroutines/methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39367 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org