https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69543&action=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 [Bug 19758] Move template JavaScript to the footer: Serials, part 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply - not completely sure how to resolve correctly. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71602|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71999&action=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71999|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72051&action=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.