https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69827&action=edit Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins This patch modifies the templates for MARC21 editor plugins so that JavaScript is included in the footer. To test, you must link the plugins to their corresponding tag + subfield (if they aren't already): In a bibliographic framework: 000 -> marc21_leader.pl 006 -> marc21_field_006.pl 007 -> marc21_field_007.pl 008 -> marc21_field_008.pl 773$t -> marc21_linking_section.tt In an authorities framework: 000 -> marc21_leader_authorities.tt 008 -> marc21_field_008_authorities.tt -> marc21_field_008_classifications.tt For each field, trigger the plugin by clicking the plugin link. Test JavaScript-driven functionality in each plugin window and confirm that your selections are correctly saved to the editor. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check and adapt for use of the new KOHA_VERSION for Javascript and switch back to Signed off :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71605|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72003&action=edit Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins This patch modifies the templates for MARC21 editor plugins so that JavaScript is included in the footer. To test, you must link the plugins to their corresponding tag + subfield (if they aren't already): In a bibliographic framework: 000 -> marc21_leader.pl 006 -> marc21_field_006.pl 007 -> marc21_field_007.pl 008 -> marc21_field_008.pl 773$t -> marc21_linking_section.tt In an authorities framework: 000 -> marc21_leader_authorities.tt 008 -> marc21_field_008_authorities.tt -> marc21_field_008_classifications.tt For each field, trigger the plugin by clicking the plugin link. Test JavaScript-driven functionality in each plugin window and confirm that your selections are correctly saved to the editor. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit: Fix for QA, add KOHA_VERSION variables to js includes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72003|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72052&action=edit Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins This patch modifies the templates for MARC21 editor plugins so that JavaScript is included in the footer. To test, you must link the plugins to their corresponding tag + subfield (if they aren't already): In a bibliographic framework: 000 -> marc21_leader.pl 006 -> marc21_field_006.pl 007 -> marc21_field_007.pl 008 -> marc21_field_008.pl 773$t -> marc21_linking_section.tt In an authorities framework: 000 -> marc21_leader_authorities.tt 008 -> marc21_field_008_authorities.tt -> marc21_field_008_classifications.tt For each field, trigger the plugin by clicking the plugin link. Test JavaScript-driven functionality in each plugin window and confirm that your selections are correctly saved to the editor. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit: Fix for QA, add KOHA_VERSION variables to js includes Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.