https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100143&action=edit Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100143|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 100177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100177&action=edit Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100177|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 100212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100212&action=edit Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.05, |20.05.00, 19.11.05, released in|19.05.10 |19.05.10, 18.11.16 CC| |hayleymapley@catalyst.net.n | |z --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.16 -- You are receiving this mail because: You are watching all bug changes.