[Bug 17464] New: Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bug ID: 17464 Summary: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: bob-ewart@bobsown.com QA Contact: testopia@bugs.koha-community.org The Allow, Deny and Order directives were deprecated in Apache 2.4 and are no longer recognized. Order deny,allow Deny from all Should be: Require all denied lines 36/37 and 169/170 in koha-httpd.conf should be changed This is in Koha compiled from source and appears in most of the versions I've tried. Also add: <Directory '/usr/share/koha'> Require all granted </Directory> or you will get an 'access forbidden' error If using plugins also add: <Directory '/var/lib/koha'> Require all granted </Directory> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bob Ewart <bob-ewart@bobsown.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart@bobsown.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still can find to "Deny from all" doing a git grep on the current codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18883 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18216 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Still a problem in 2020. I was just setting up Koha 19.11 from source and etc/koha-httpd.conf is still set up for Apache 2.2. (I may as well take a minute to write a patch for this now.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 97294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97294&action=edit Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Note that I'm only fixing the existing access control issue. I haven't added a patch regarding potentially missing Directory directives. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97294|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99679&action=edit Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Old syntax still valid with mod_access_compat, but not for long. Works, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99679|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99839&action=edit Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Old syntax still valid with mod_access_compat, but not for long. Works, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And another one (bug) bites the dust... Verified by reading the patch and checking with my notes from strugglng with Apache2 back then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00, 19.11.05, |20.05.00, 19.11.05, released in|19.05.10 |19.05.10, 18.11.16 --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.16 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org