[Bug 18636] New: Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Bug ID: 18636 Summary: Can not save new patron on fresh install (Conflict between autoMemberNum and BorrowerMandatoryField) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Tested on a fresh install on current master To reproduce: - Go to Koha > Patrons > Add patron (full form) - Verify that label for card number reads: "Card number(leave blank for auto calc during registration):" - Do not enter anything in field card number - Enter surname, try to save - Form does not save because field card number is required Reason: - autoMemberNum is on by default (sysprefs.sql line 65) - BorrowerMandatoryField contains surname|cardnumber by default (sysprefs.sql line 86) - Full form does not save because card number is mandatory and empty Note: With quick add form and settings above, cardnumber is not displayed, form saves properly. What to do? - Better explanation for autoMemberNum and BorrowerMandatoryField - Set defaults for autoMemberNum and BorrowerMandatoryField in a way that they do not conflict? - Ignore cardnumber being a mandatory field if autoMemberNum is on? - Ask for settings in onboarding tool? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Krishna K <krishna.moorthy94@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krishna.moorthy94@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #1 from Krishna K <krishna.moorthy94@gmail.com> --- Hi, We are using Koha 17.05.01 with MySQL. When we try to add a patron, the card number field is not getting autogenerated and save is failing. Automembernum is enabled and BorrowerMandatoryField contains cardnumber. I see no contradiction in these parameters. This was working perfectly fine in 16.05. What could be going wrong ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Krishna, this is more of a support question I think and would be better on the mailing list or in IRC. Please state which version of MySQL you are using. If it's 5.7 or later it's strongly recommended you switch to MariaDB as there are a lot of known problems with 5.7 being more strict. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 65699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65699&action=edit Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #4 from Krishna K <krishna.moorthy94@gmail.com> --- Hi, The documentation as part of the patch says if AutoMemberNum is ON, then BorrowerMandatoryField should not contain cardnumber. If I remove cardnumber from the BorrowerMandatoryField, then on adding a patron a long number gets generated as the card number.This is happening after upgrading to 17.05. Earlier, we were using 16.05 and there the card number was getting auto generated by adding one to the last added patron's card number. So we had numbers like say 125, 126 etc(we are a small library) whereas the settings suggested in 17.05 leaves us with an unwieldy 14 digit card number. Katrin, I will reconfirm on the MySQL version. Am not sure about that. Do you think this is related to the autoincrement issue at the database level ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this might not be an update issue. The cardnumber is generated by looking for the biggest used number in your database and adding 1. If you do something like: select max(cardnumber) from borrowers; what does it give you? If you want to get back to low numbers, you might just have to clean up a few records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65699|0 |1 is obsolete| | --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66516&action=edit Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields Followed test plan, works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jlamb@lcsdnv.com --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19224 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about a warning on the about page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225 [Bug 19225] Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #8)
What about a warning on the about page?
See Bug 19225 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66516|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66730&action=edit Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields Followed test plan, works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org