[Bug 18692] New: When SMS is enabled the OPAC messaging table is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Bug ID: 18692 Summary: When SMS is enabled the OPAC messaging table is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. I think the SMS column is missing an else case with cell containing only "-" like other columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 [Bug 6458] incorrect parsing result in translation processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 [Bug 6726] When SMS is enabled the messaging table is misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63814&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11125 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63830&action=edit Email notifications can no longer be edited with patch Patch is applied, syspref SMSSendDriver is empty. Result: In column email we have a minus sign (-) instead of check boxes as without patch. See screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |axelle.clarisse@univ-amu.fr --- Comment #3 from Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> --- Patch tested on sandbox 1 by Biblibre. I agree with Marc Véron. When syspref SMSDriver is full filled (for example with email), columns are ok. When syspref SMSDriver is empty, it doesn't work because in column email we should see check boxes instead of "-". Check boxes should be in colunm email and in column not notify to allow our user to choose the messages they want to receive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@jns.fi --- Comment #4 from Lari Taskula <lari.taskula@jns.fi> --- I'm not sure I understood the original problem, perhaps screenshots would help. Is message_transports / message_transport_types table properly configured? Anyway I actually wanted to comment that I also noticed "sms" is missing "-" in the messaging preferences table both in OPAC and staff when it has no sms transport configured in message_transports database table. The same for "phone". To my understanding, message_transports table defines availability of transport options for the messaging preferences table. sms and phone should not have checkboxes when they are removed from those options. This feature used to exist but for some reason the "-" got completely removed to fix misalignment issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #5 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 63872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63872&action=edit Bug 18692: (follow-up) Fix misplaced columns and add this feature for phone as well Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ahhhh, I did not see that the TT vars where different : messaging_preference.transport_sms and messaging_preference.transport[s]_sms I will correct my path. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63897&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63898&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63898|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63900&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. https://bugs.koha-community.org/show_bug.cgi?id=8692 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- @Lari Taskula, I have adapted you patch. Tell me if its ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Michael Cabus <michael@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Michael Cabus <michael@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63897|0 |1 is obsolete| | --- Comment #11 from Michael Cabus <michael@bywatersolutions.com> --- Created attachment 64409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64409&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Michael Cabus <michael@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63900|0 |1 is obsolete| | --- Comment #12 from Michael Cabus <michael@bywatersolutions.com> --- Created attachment 64410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64410&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. https://bugs.koha-community.org/show_bug.cgi?id=8692 Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64409|0 |1 is obsolete| | Attachment #64410|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65170&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65171&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. https://bugs.koha-community.org/show_bug.cgi?id=8692 Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Patches work nicely, Lari's patches included fixes for the intranet as well and those seem to have been dropped. Can we add those back in? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #15)
Patches work nicely, Lari's patches included fixes for the intranet as well and those seem to have been dropped. Can we add those back in?
Oh indeed. I create a follow up from patch https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63872 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 65451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65451&action=edit Bug 18692 - intranet part Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intranet messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65451|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65906&action=edit [SIGNED-OFF] Bug 18692 - intranet part Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intranet messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65906|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66731&action=edit Bug 18692 - intranet part Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intranet messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org