[Bug 15983] New: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Bug ID: 15983 Summary: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl?o p=del&id=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 15785 If you try to delete a serials numbering pattern which is in use by an existing subscription you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48702&action=edit Bug 15983 - Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48702|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48751&action=edit [SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48751|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48944&action=edit Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org