https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48689|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48691&action=edit [SIGNED-OFF]Bug 15978: Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated <form> tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <<foo|bar>> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|/cgi-bin/koha/admin/marctag |/cgi-bin/koha/reports/guide |structure.pl |d_reports.pl?phase=Create | |report from SQL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48691|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48942&action=edit Bug 15978: Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated <form> tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <<foo|bar>> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.