[Bug 28456] New: Add option to use a WHERE statement in membership_expiry.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Bug ID: 28456 Summary: Add option to use a WHERE statement in membership_expiry.pl cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send - adding a where statement will allow for flexibility -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121397&action=edit Bug 28456: Add WHERE option to membership_expiry cronjob Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send. Adding a where statement will allow for flexibility To test: 1 - Set some borrowers to expire soon 2 - Set MembershipExpiryDaysNotice to 10 3 - perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 4 - Note the patrons that yo uadjusted show up 5 - Limit by various patron fields, e.g. perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NOT NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname LIKE '%a%'" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname NOT LIKE '%a%'" 6 - Confirm expected results 7 - perl misc/cronjobs/membership_expiry.pl 8 - Confirm the help message makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121397|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121922&action=edit Bug 28456: Add WHERE option to membership_expiry cronjob Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send. Adding a where statement will allow for flexibility To test: 1 - Set some borrowers to expire soon 2 - Set MembershipExpiryDaysNotice to 10 3 - perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 4 - Note the patrons that yo uadjusted show up 5 - Limit by various patron fields, e.g. perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NOT NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname LIKE '%a%'" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname NOT LIKE '%a%'" 6 - Confirm expected results 7 - perl misc/cronjobs/membership_expiry.pl 8 - Confirm the help message makes sense Signed-off-by: Azucena Aguayo <azucena.aguayo@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121922|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124133&action=edit Bug 28456: Add WHERE option to membership_expiry cronjob Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send. Adding a where statement will allow for flexibility To test: 1 - Set some borrowers to expire soon 2 - Set MembershipExpiryDaysNotice to 10 3 - perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 4 - Note the patrons that yo uadjusted show up 5 - Limit by various patron fields, e.g. perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NOT NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname LIKE '%a%'" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname NOT LIKE '%a%'" 6 - Confirm expected results 7 - perl misc/cronjobs/membership_expiry.pl 8 - Confirm the help message makes sense Signed-off-by: Azucena Aguayo <azucena.aguayo@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Replace two inclue by include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note: There is no checking on the $where values. Passing invalid columns will crash the script etc. No blocker to me for this cron job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26062 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |Add an optional `--where` release notes| |parameter to the | |`membership_expiry.pl` | |task. This allows for | |arbitrarily complex SQL | |where statements to be | |passed to the script to | |filter affected patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31787 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Susan <susan.merner@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susan.merner@nhs.net --- Comment #6 from Susan <susan.merner@nhs.net> --- Comment on attachment 124133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124133 Bug 28456: Add WHERE option to membership_expiry cronjob I would like to be able to ensure students who are on short placement of 3 weeks do not get the expiry email at all. Excluding a specific university (UMED) would assist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 26062 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org