[Bug 41649] New: Add support for setting the magnetic media flag for SIP in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Bug ID: 41649 Summary: Add support for setting the magnetic media flag for SIP in Koha Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Bug 11351 added the ability to select a media type for SIP responses, however it didn't set the related 'magnetic' bit for SIP. We could hard code that based on media type, but it would be cleaner to allow configuration at the item type level. I'll post two patches here.. the first we've been running in production for around a decade and I thought I'd posted it years ago but can't find it.. the second making it more flexible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191552&action=edit Bug 41649: Set magnetic_media in SIP responses The `magnetic_media` flag was never set, it can be set from `sip_media_type` if it's present. `sip_media_type` is set via the Authorized Values system. Checkins will not be sorted correctly by Biblioteca without this flag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191553&action=edit Bug 41649: Add sip_magnetic field to itemtypes table This patch adds the new sip_magnetic boolean flag field to the itemtypes table to allow flagging the itemtype as magnetic for sip responses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191554&action=edit Bug 41649: DBIC Build Patch from commit 020392b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191555&action=edit Bug 41649: Add option to set magnetic flag for item itemtypes This patch adds the ability to set an item type as magentic for SIP response purposes. Test plan: 1) Run included database updates 2) Navigate to admin > itemtypes 3) Edit/Add an itemtype and scroll to the 'Sip media types' input 4) A new 'Sip magnetic' checkbox should be available 5) Confirm setting/unsetting it works as expected 6) The SIP magnetic flag bit should respect the setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191556&action=edit Bug 41649: Unit tests for magnetic media Add unit tests for SIP magnetic media support. Test plan 1) Run t/db_dependent/SIP/Transaction.t in ktd and confirm it passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Comma delimited| |OpenFifth list of Sponsors| |<https://openfifth.co.uk/> QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191552|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191554|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191555|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191556|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191673&action=edit Bug 41649: Set magnetic_media in SIP responses The `magnetic_media` flag was never set, it can be set from `sip_media_type` if it's present. `sip_media_type` is set via the Authorized Values system. Checkins will not be sorted correctly by Biblioteca without this flag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191674&action=edit Bug 41649: Add sip_magnetic field to itemtypes table This patch adds the new sip_magnetic boolean flag field to the itemtypes table to allow flagging the itemtype as magnetic for sip responses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191675&action=edit Bug 41649: DBIC Build Patch from commit 0e07ede -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191676&action=edit Bug 41649: Add option to set magnetic flag for item itemtypes This patch adds the ability to set an item type as magentic for SIP response purposes. Test plan: 1) Run included database updates 2) Navigate to admin > itemtypes 3) Edit/Add an itemtype and scroll to the 'Sip media types' input 4) A new 'Sip magnetic' checkbox should be available 5) Confirm setting/unsetting it works as expected 6) The SIP magnetic flag bit should respect the setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191677&action=edit Bug 41649: Unit tests for magnetic media Add unit tests for SIP magnetic media support. Test plan 1) Run t/db_dependent/SIP/Transaction.t in ktd and confirm it passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191678&action=edit Bug 41649: Fix SIP Message tests for magnetic media The tests for desensitize and alert flags were failing because items were created with random itemtypes that could have sip_magnetic=1. This caused unexpected behavior since magnetic media items don't get desensitized and trigger alert flags. Fix by explicitly creating itemtypes with sip_magnetic=0 in: - test_checkout_desensitize - test_renew_desensitize - test_checkin_v2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191679&action=edit Bug 41649: DBIC Schema boolean update Patch from commit 8b7d205 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191674|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191677|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191679|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191680&action=edit Bug 41649: Set magnetic_media in SIP responses The `magnetic_media` flag was never set, it can be set from `sip_media_type` if it's present. `sip_media_type` is set via the Authorized Values system. Checkins will not be sorted correctly by Biblioteca without this flag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191681&action=edit Bug 41649: Add sip_magnetic field to itemtypes table This patch adds the new sip_magnetic boolean flag field to the itemtypes table to allow flagging the itemtype as magnetic for sip responses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191682&action=edit Bug 41649: DBIC Build Patch from commit 28c2663 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191683&action=edit Bug 41649: Add option to set magnetic flag for item itemtypes This patch adds the ability to set an item type as magentic for SIP response purposes. Test plan: 1) Run included database updates 2) Navigate to admin > itemtypes 3) Edit/Add an itemtype and scroll to the 'Sip media types' input 4) A new 'Sip magnetic' checkbox should be available 5) Confirm setting/unsetting it works as expected 6) The SIP magnetic flag bit should respect the setting 7) To test SIP functionality: a) Start the SIP server (e.g., koha-sip service) b) Create an item with an itemtype that has sip_magnetic checked c) Use misc/sip_cli_emulator.pl to send a checkout request: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su <sip_username> -sp <sip_password> -l <location_code> --patron <patron_cardnumber> --password <patron_password> --item <item_barcode> -m checkout d) Check the SIP response to ensure it handles magnetic media correctly (e.g., no desensitization flag) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191684&action=edit Bug 41649: Unit tests for magnetic media Add unit tests for SIP magnetic media support. Test plan 1) Run t/db_dependent/SIP/Transaction.t in ktd and confirm it passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191685&action=edit Bug 41649: Fix SIP Message tests for magnetic media The tests for desensitize and alert flags were failing because items were created with random itemtypes that could have sip_magnetic=1. This caused unexpected behavior since magnetic media items don't get desensitized and trigger alert flags. Fix by explicitly creating itemtypes with sip_magnetic=0 in: - test_checkout_desensitize - test_renew_desensitize - test_checkin_v2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191686&action=edit Bug 41649: DBIC Schema boolean update Patch from commit f546c71 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191680|0 |1 is obsolete| | Attachment #191681|0 |1 is obsolete| | Attachment #191682|0 |1 is obsolete| | Attachment #191683|0 |1 is obsolete| | Attachment #191684|0 |1 is obsolete| | Attachment #191685|0 |1 is obsolete| | Attachment #191686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200925&action=edit Bug 41649: Set magnetic_media in SIP responses The `magnetic_media` flag was never set, it can be set from `sip_media_type` if it's present. `sip_media_type` is set via the Authorized Values system. Checkins will not be sorted correctly by Biblioteca without this flag. Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200926&action=edit Bug 41649: Add sip_magnetic field to itemtypes table This patch adds the new sip_magnetic boolean flag field to the itemtypes table to allow flagging the itemtype as magnetic for sip responses. Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200927&action=edit Bug 41649: DBIC Build Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200928&action=edit Bug 41649: Add option to set magnetic flag for item itemtypes This patch adds the ability to set an item type as magentic for SIP response purposes. Test plan: 1) Run included database updates 2) Navigate to admin > itemtypes 3) Edit/Add an itemtype and scroll to the 'Sip media types' input 4) A new 'Sip magnetic' checkbox should be available 5) Confirm setting/unsetting it works as expected 6) The SIP magnetic flag bit should respect the setting 7) To test SIP functionality: a) Start the SIP server (e.g., koha-sip service) b) Create an item with an itemtype that has sip_magnetic checked c) Use misc/sip_cli_emulator.pl to send a checkout request: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su <sip_username> -sp <sip_password> -l <location_code> --patron <patron_cardnumber> --password <patron_password> --item <item_barcode> -m checkout d) Check the SIP response to ensure it handles magnetic media correctly (e.g., no desensitization flag) Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200929&action=edit Bug 41649: Unit tests for magnetic media Add unit tests for SIP magnetic media support. Test plan 1) Run t/db_dependent/SIP/Transaction.t in ktd and confirm it passes Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200930&action=edit Bug 41649: Fix SIP Message tests for magnetic media The tests for desensitize and alert flags were failing because items were created with random itemtypes that could have sip_magnetic=1. This caused unexpected behavior since magnetic media items don't get desensitized and trigger alert flags. Fix by explicitly creating itemtypes with sip_magnetic=0 in: - test_checkout_desensitize - test_renew_desensitize - test_checkin_v2 Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200931&action=edit Bug 41649: DBIC Schema boolean update Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200929|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #27 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201067&action=edit Bug 41649: Set magnetic_media in SIP responses The `magnetic_media` flag was never set, it can be set from `sip_media_type` if it's present. `sip_media_type` is set via the Authorized Values system. Checkins will not be sorted correctly by Biblioteca without this flag. Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #28 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201068&action=edit Bug 41649: Add sip_magnetic field to itemtypes table This patch adds the new sip_magnetic boolean flag field to the itemtypes table to allow flagging the itemtype as magnetic for sip responses. Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #29 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201069&action=edit Bug 41649: DBIC Build Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #30 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201070&action=edit Bug 41649: Add option to set magnetic flag for item itemtypes This patch adds the ability to set an item type as magentic for SIP response purposes. Test plan: 1) Run included database updates 2) Navigate to admin > itemtypes 3) Edit/Add an itemtype and scroll to the 'Sip media types' input 4) A new 'Sip magnetic' checkbox should be available 5) Confirm setting/unsetting it works as expected 6) The SIP magnetic flag bit should respect the setting 7) To test SIP functionality: a) Start the SIP server (e.g., koha-sip service) b) Create an item with an itemtype that has sip_magnetic checked c) Use misc/sip_cli_emulator.pl to send a checkout request: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su <sip_username> -sp <sip_password> -l <location_code> --patron <patron_cardnumber> --password <patron_password> --item <item_barcode> -m checkout d) Check the SIP response to ensure it handles magnetic media correctly (e.g., no desensitization flag) Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #31 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201071&action=edit Bug 41649: Unit tests for magnetic media Add unit tests for SIP magnetic media support. Test plan 1) Run t/db_dependent/SIP/Transaction.t in ktd and confirm it passes Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #32 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201072&action=edit Bug 41649: Fix SIP Message tests for magnetic media The tests for desensitize and alert flags were failing because items were created with random itemtypes that could have sip_magnetic=1. This caused unexpected behavior since magnetic media items don't get desensitized and trigger alert flags. Fix by explicitly creating itemtypes with sip_magnetic=0 in: - test_checkout_desensitize - test_renew_desensitize - test_checkin_v2 Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #33 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201073&action=edit Bug 41649: DBIC Schema boolean update Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Marcus Michel <marcus.michel@rbkc.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 --- Comment #34 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41649 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org