[Bug 32675] New: Cannot add a guarantor when there is a single quote in the guarantor attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Bug ID: 32675 Summary: Cannot add a guarantor when there is a single quote in the guarantor attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: hammat.wele@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the "Alternate address" or "Contact information" fields (like the "Address" field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on "Add guarantor" 4. Search for the patron 2 5. Click on "Select" --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 145403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145403&action=edit Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the Address field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on Select --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 145404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145404&action=edit Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145404|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145490&action=edit Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145490|0 |1 is obsolete| | --- Comment #4 from solene.ngamga@inlibro.com --- Created attachment 145880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145880&action=edit Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147169&action=edit Bug 32675: [alternative patch] Fix guarantor selection when simple quote present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this patch is less hazardous, we let the escape to JS internal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147169|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147699&action=edit Bug 32675: [alternative patch] Fix guarantor selection when simple quote present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hammat.wele@inlibro.com |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147699|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147727&action=edit Bug 32675: [alternative patch] Fix guarantor selection when simple quote present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- Lucas, can this be back ported to 22.5? I can't expect our staff to do the gymnastics required to get around this until 22.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #12)
Backported to 22.05.x for upcoming 22.05.11
That is good news. Thanks for doing this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This one doesn't apply cleanly on 21.11, conflicts is not trivial to fix. Won't backport unless patch provided -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 32233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org