[Bug 29471] New: MARC21: 520 - Summary etc. doesn't display in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Bug ID: 29471 Summary: MARC21: 520 - Summary etc. doesn't display in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When the display for 520 was added to the OPAC, staff interface was missed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152906&action=edit Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152906|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 152908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152908&action=edit Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Phil! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to enh. Can understand the inital choice for normal btw.. But at the end every enhancement is a bug fix :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Patience is a good thing: commit 668581b72022c6c0a46b6ccb5f607921f633e1f6 Author: Frédéric Demians <f.demians@tamil.fr> Date: Sun Nov 8 10:28:59 2009 +0100 Improve detail page MARC21 XSL file for 505 and 520 tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + <xsl:call-template name="subfieldSelect"> + <xsl:with-param name="codes">abcu</xsl:with-param> + </xsl:call-template> 520$u is a URL. Please adjust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #6)
+ <xsl:call-template name="subfieldSelect"> + <xsl:with-param name="codes">abcu</xsl:with-param> + </xsl:call-template>
520$u is a URL. Please adjust
Can we do this separately? This is just a copy of the OPAC display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #7)
(In reply to Marcel de Rooy from comment #6)
+ <xsl:call-template name="subfieldSelect"> + <xsl:with-param name="codes">abcu</xsl:with-param> + </xsl:call-template>
520$u is a URL. Please adjust
Can we do this separately? This is just a copy of the OPAC display.
It is 5 minutes of work. Please do it here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is finding the 5 minutes currently, silly as it sounds... I'll try, but not sure when. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152908|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153474&action=edit Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Updated patch for displaying $u as link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marcel: I messed up the rebase so I ended up with only one patch. If you think it's needed, please push back to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a side note, no blocker: + <xsl:if test="marc:subfield[@code='u']"> + <xsl:for-each select="marc:subfield[@code='u']"> The if test is fine, but actually not needed. If you only have the foreach and there is no $u, nothing happens too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153474|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153528&action=edit Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Updated patch for displaying $u as link. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Restored signoff line from Phil. Change only for $u. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #12)
Just a side note, no blocker:
+ <xsl:if test="marc:subfield[@code='u']"> + <xsl:for-each select="marc:subfield[@code='u']">
The if test is fine, but actually not needed. If you only have the foreach and there is no $u, nothing happens too.
You are right. Tbh I stole this code from another 5xx with $u for some consistency :) Also thank you for adding back the sign-off line - I forgot about it when I rebased my local branch for the addition. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org