[Bug 32633] New: Add 'page-section' to cataloging and authority pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Bug ID: 32633 Summary: Add 'page-section' to cataloging and authority pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 A few cataloging and authority templates need to have main content wrapped in a "page-section" container. - includes/merge-record.inc - authorities/searchresultlist.tt - cataloguing/addbooks.tt - cataloguing/additem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145302&action=edit Bug 32633: Add 'page-section' to cataloging and authority pages This patch adds a "page-section" container div around the main section of cataloging and authority pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Cataloging -> Cataloging search results - Cataloging -> Edit items: The table of items and the item edit form should each be contained in a page-section. - Authorities -> Search results - Authorites -> Merge authorities: From the authorities search results list, click "Actions -> Merge" for one result, and then "Actions -> Merge" for another. - Click "Next" after selecting a merge reference. - The "Destination record" information should be contained in a page-section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, Should the page section on cataloging search include the pagination links? I know it is not a dataTable but I am comparing it to item search. I am still a bit confused on what the standard should be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145302|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145340&action=edit Bug 32633: Add 'page-section' to cataloging and authority pages This patch adds a "page-section" container div around the main section of cataloging and authority pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Cataloging -> Cataloging search results - Cataloging -> Edit items: The table of items and the item edit form should each be contained in a page-section. - Authorities -> Search results - Authorites -> Merge authorities: From the authorities search results list, click "Actions -> Merge" for one result, and then "Actions -> Merge" for another. - Click "Next" after selecting a merge reference. - The "Destination record" information should be contained in a page-section. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just realized.. I SO here. Can someone else take it for QA please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145340|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145872&action=edit Bug 32633: Add 'page-section' to cataloging and authority pages This patch adds a "page-section" container div around the main section of cataloging and authority pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Cataloging -> Cataloging search results - Cataloging -> Edit items: The table of items and the item edit form should each be contained in a page-section. - Authorities -> Search results - Authorites -> Merge authorities: From the authorities search results list, click "Actions -> Merge" for one result, and then "Actions -> Merge" for another. - Click "Next" after selecting a merge reference. - The "Destination record" information should be contained in a page-section. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145873&action=edit Bug 32633: (QA follow-up) Move page-section nesting This follow-up makes a small change to the page-section nesting on the Cataloging and Authorities search results pages. We move the 'h2' outside of the page section but include the paging and number of results inside with the results tables themselves. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145874&action=edit Bug 32633: (QA follow-up) Add handling for authorities merge When you first click 'actions -> merge' from a result in the authories search page you will see a new 'Merging with authority: ' text appear at the top of the search results. Prior to this patch, the text appears outside of the white page-section and is almost un-noticable. After this patch, we add a page-section with bg-info (blue backround) around the merge message which makes it stand up more clearly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agreed with Lucas on the pageing so did that as a QA follow-up. It also highlighted to me that the merge message wasn't entirely clear sitting outside the page-section but without any background of it's own.. So I added a further QA follow-up to clarify that too. No regressions found and code all passes QA tests... Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Bug 32633 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org