[Bug 37525] New: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Bug ID: 37525 Summary: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: oliver.behnke@aei.mpg.de QA Contact: testopia@bugs.koha-community.org Created attachment 169856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169856&action=edit Patch to fix the regression There's a regression in bug 32256 and commit bb059abe respectively: https://gitlab.com/koha-community/Koha/-/commit/bb059abe90#a22dc682a84c41672... The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met. The attached patch should do. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32256 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26479 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't forget to switch to "Needs signoff" when you upload a patch - this will make it visible to the testers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oliver.behnke@aei.mpg.de |ity.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After taking a closer look, there are some more stumbling stones: The attached file is not a patch file, but a diff and needs some work before it can be tested with our tools. The commit message should include a test plan and also the bug number in the first line, see: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and let us know if we can help :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #4 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Just use the diff for additional illustration purposes then. I don't mind if the patch attribution gets lost and someone else takes the credit :) Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@hypern | |ova.fi --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- (In reply to Oliver Behnke from comment #4)
Just use the diff for additional illustration purposes then. I don't mind if the patch attribution gets lost and someone else takes the credit :)
Cheers
Hi! I had implemented exactly the same solution to one of our customers two weeks ago. I applied it at Bug 26479. If you could kindly go sign it off, we could get this ball rolling, thank you. It is exactly the solution you did so I presume you have it working somewhere with a real client already so should be easy to verify it works. Unfortunately it doesn't fix the other problem of being unable to checkin books from the list of open issues. But I felt like the user should not be able to check-in books from that list, because there is no guarantee the user actually has the book. It is better to require them to read the barcode instead, so they wont accidentally checkin books they were not supposed to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- *** This bug has been marked as a duplicate of bug 26479 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #7 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Olli-Antti, I don't think this is an obvious duplicate of 26479 as I tried to describe in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479#c3. That's why I opened this bug here in the first place. If our fix also does the job for Katrin's original issue than great, but that should be up to her to confirm. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #8 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- (I'd really love to be able to edit comments to fix typos...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- Sorry for jumping ahead again and closing this. Thank you for being considerate. See Bug 26479 for Katrin's comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169856|0 |1 is obsolete| | --- Comment #10 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Created attachment 170870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170870&action=edit Patch to fix the regression While at it again, turn this into a proper patch against 'main'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171034&action=edit Bug 37525: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed There's a regression in bug 32256 and commit bb059abe respectively: https://gitlab.com/koha-community/Koha/-/commit/bb059abe90#a22dc682a84c41672... The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met. This fixes the issue and restores the original functionality. Test plan: 1. log in with a patron at http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. check out an item 3. scan it again 4. see that the "return this item" choice isn't proposed. This is the bug 5. apply patches 6. rescan the item in the self-check out 7. returning is proposed 8. check it in and confirms that it's not checked out anymore Signed-off-by: Oliver Behnke <oliver.behnke@aei.mpg.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the fix Oliver. For proofreading, you can see in the above attachment the added test plan that would correspond to the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #13 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks Victor! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[SCO] Regression in 32256: |[SCO] "Return this item" |"Return this item" doesn't |doesn't show up in scan |show up despite |confirmation screen despite |SCOAllowCheckin being |SCOAllowCheckin being |allowed |allowed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32256 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32256 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 [Bug 32256] Self checkout batch mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #14 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- (In reply to Victor Grousset/tuxayo from comment #12)
Thanks for the fix Oliver. For proofreading, you can see in the above attachment the added test plan that would correspond to the fix.
Thanks Victor! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171034|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172118&action=edit Bug 37525: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed There's a regression in bug 32256 and commit bb059abe respectively: https://gitlab.com/koha-community/Koha/-/commit/bb059abe90#a22dc682a84c41672... The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met. This fixes the issue and restores the original functionality. Test plan: 1. log in with a patron at http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. check out an item 3. scan it again 4. see that the "return this item" choice isn't proposed. This is the bug 5. apply patches 6. rescan the item in the self-check out 7. returning is proposed 8. check it in and confirms that it's not checked out anymore Signed-off-by: Oliver Behnke <oliver.behnke@aei.mpg.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #17 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks everyone! Given that this is a trivial fix for regression, is this going to be backported to older releases? If so, who is the next assignee in the process? Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Bug 37525 depends on bug 32256, which changed state. Bug 32256 Summary: Self checkout batch mode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Oliver Behnke from comment #17)
is this going to be backported to older releases? If so, who is the next assignee in the process?
Don't worry, backporting is a systematic process. See the criteria for general guidelines of how far down patches are backported: https://wiki.koha-community.org/wiki/Release_maintenance#Deciding_on_what_to... And the process is explicit. So there should be in the coming weeks messages here on each backporting by the release maintainers until the explicit end of the process. If there is no activity before the 22th of this month (date of the monthly minor releases), then you can head over to the chat or the development mailing list. To ask for more info about the status of this and who to ask confirmation that it's still on their todo list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
backporting is a systematic process
(systematic evaluation of backportability, in addition of the guidelines, there are case by case consideration and eventual complications) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 --- Comment #20 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks. I just wanted to make sure that I (as the current assignee) am not the bottleneck :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[SCO] "Return this item" |Self checkout: "Return this |doesn't show up in scan |item" doesn't show up in |confirmation screen despite |scan confirmation screen |SCOAllowCheckin being |despite SCOAllowCheckin |allowed |being allowed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37525 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32256 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org