[Bug 30965] New: Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Bug ID: 30965 Summary: Add patron autocomplete search to curbside pickups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30578, 30650 So far it's only possible to search for patrons by cardnumber. We should add the regular patron autocomplete search to allow search by surname and firstname. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Convert the Curbside Pickup plugin to Koha core -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alissa.desaintlaurent@univ- | |brest.fr, | |sonia.bouis@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136583&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is ready for testing, see test plans in patch "Bug 30650: Admin page" and "Bug 30650: Add circulation page view" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136583|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137097&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #4 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, tested on a sandbox on the top of BZ30650 and it works as expected. On the "schedule pickup" tab of the curbside pickups table, you can search the patron with his name and you tye 3 letters, you have an autocompletion. Thanks Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137097|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137309&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My problem with the patron search here is that you get 'stuck' on it. Search for a patron, pick it - names were all similar, it's not the right one! There is no way to reset the form. You'd have to schedule a curbside pickup (which sends an email) and remove it again to get out of it. Can we have some kind of reset button to get back to search? Not for this bug, but how do people feel about having a way to open an 'advanced search' (like the normal pop-up) with a button if needed? We've had complaints form libraries with lots of patrons with very similar names in the past and this might help them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138402&action=edit Bug 30965: Add a 'x' to go back to the patron search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Is that what you wanted? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137309|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138420&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138402|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138421&action=edit Bug 30965: Add a 'x' to go back to the patron search Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8)
Is that what you wanted?
Yes, that's much better - thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/617/ Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Bug 30965 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Bug 30965 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37983 [Bug 37983] "Search a patron" box no longer has auto focus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38676 [Bug 38676] Incorrect label for input-patron-cardnumber in curbside_pickups.tt -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org