[Bug 26534] New: Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Bug ID: 26534 Summary: Add Font Awesome icon only for staff patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110717&action=edit Screenshot Screenshot of staff patron detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110718&action=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110718|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 110738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110738&action=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110738|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110739&action=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice enhancement, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- + .staffgrade { h5 { background-color: #EEE; } } This rule doesn't work as I think it is intended. If the staff name heading is to have a background color it should be written as: &.staffgrade { h5 { background-color: #EEE; } } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110749&action=edit Bug 26534: (QA follow-up) Fix CSS declaration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110750&action=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting back to Signed off to get a second QA opinion as I missed the CSS issue first time around :(. I've corrected the CSS issue with a QA followup, but it also brought my attention to how the centered names looked when patronimages were not in use.. I felt they didn't look right in that case so have added a followup which should be looked at distinctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110750|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110753&action=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110753|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110754&action=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Discussed in IRC and followup cleaned as per discussion.. Setting back to PQA as we seemed happy as a group :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Maybe avoid duplicated code this : [% IF ( patronimages ) %] <h5 class="text-center"> [% ELSE %] <h5> [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fridolin, "grade" does not sound appropriate, could you use is_superlibrarian for instance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14)
Fridolin, "grade" does not sound appropriate, could you use is_superlibrarian for instance?
would actually be "is_staff" in this context :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #15)
(In reply to Jonathan Druart from comment #14)
Fridolin, "grade" does not sound appropriate, could you use is_superlibrarian for instance?
would actually be "is_staff" in this context :)
Yep ok no problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #13)
Maybe avoid duplicated code this :
[% IF ( patronimages ) %] <h5 class="text-center"> [% ELSE %] <h5> [% END %]
Bah forget it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110960&action=edit Bug 26534: Replace 'grade' by 'is-patron' and 'patron-type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Looks great now, needs a final signoff ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Fridolin SOMERS from comment #17)
(In reply to Fridolin SOMERS from comment #13)
Maybe avoid duplicated code this :
[% IF ( patronimages ) %] <h5 class="text-center"> [% ELSE %] <h5> [% END %]
Bah forget it.
Sorry, it wasn't a bad idea.. I just hadn't gotten around to it..I'm happy with it either way really myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #20)
(In reply to Fridolin SOMERS from comment #17)
(In reply to Fridolin SOMERS from comment #13)
Maybe avoid duplicated code this :
[% IF ( patronimages ) %] <h5 class="text-center"> [% ELSE %] <h5> [% END %]
Bah forget it.
Sorry, it wasn't a bad idea.. I just hadn't gotten around to it..I'm happy with it either way really myself.
Ah OK super, i patch :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #22 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110972&action=edit Bug 26534: Use IF ELSE directly on h5 opening tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Something has gone wrong with these patches... Looks like maybe a merge error? They apply but I get an error. "Template process failed: file error - parse error - circ-menu.inc line 181: unexpected end of input" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110972|0 |1 is obsolete| | --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110995&action=edit Bug 26534: Use IF ELSE directly on h5 opening tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #23)
Something has gone wrong with these patches... Looks like maybe a merge error? They apply but I get an error. "Template process failed: file error - parse error - circ-menu.inc line 181: unexpected end of input"
Ah of course : IF, ELSE, was missing END ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110739|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 111185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111185&action=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110749|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 111186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111186&action=edit Bug 26534: (QA follow-up) Fix CSS declaration Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110754|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 111187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111187&action=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110960|0 |1 is obsolete| | --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 111188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111188&action=edit Bug 26534: Replace 'grade' by 'is-patron' and 'patron-type' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110995|0 |1 is obsolete| | --- Comment #30 from David Nind <david@davidnind.com> --- Created attachment 111189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111189&action=edit Bug 26534: Use IF ELSE directly on h5 opening tag Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #31 from David Nind <david@davidnind.com> --- This is the test plan I used: 1. In a tab open a patron record for a staff member who has at least 'Staff access..." permissions. 2. In another tab enable the patronimages system preference: . Go to Home > Koha administration . Search for the patronimages system preference . Change to 'Allow' 3. In the same tab load the same patron as used in step 1. 4. Apply the patch. 5. Update the staff interface CSS: see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 6. In yet another tab open the same patron record as in step 1. 7. It should look similar to the screenshot attached to the bug, with the shield icon, patron name and card number centred above the image with a light grey background. 8. Experiment with different browser widths to make sure things display nicely. 9. Turn off the patronimages system preference (Home > Koha administration > search for patronimages > change to 'Don't allow'). 10. Refresh the patron page. 11. It should display the shield icon, patron name, and card number left aligned with a light grey background. 12. Experiment with different browser widths to make sure things display nicely. 13. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111185|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111648&action=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111186|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111649&action=edit Bug 26534: (QA follow-up) Fix CSS declaration Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111187|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111650&action=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111188|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111651&action=edit Bug 26534: Replace 'grade' by 'is-patron' and 'patron-type' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111189|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111652&action=edit Bug 26534: Use IF ELSE directly on h5 opening tag Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Font Awesome icon only |Add Font Awesome icon to |for staff patrons |help identify staff patrons --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this and think it would be nice in other spots like the patron search as well. But this is a solid start. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #38 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh now I see that my code : [% SET patron_is_staff = patron.has_permission({ 'catalogue' => 1 }) %] Could have used existing var [% IF ( CAN_user_catalogue ) %]. Do I change ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Fridolin SOMERS from comment #38)
Oh now I see that my code : [% SET patron_is_staff = patron.has_permission({ 'catalogue' => 1 }) %]
Could have used existing var [% IF ( CAN_user_catalogue ) %].
Do I change ?
tl:dr; Keep is as is. In this case, I actually like the addition of the patron_is_staff variable as it makes it clear we're not so much looking for 'cataglogue' as we're trying to just distinguish if the user is staff or not (In the future, we might eventually add role based access control).. also, CAN_user_catalogue is at the currently logged in user level, rather than on the patron we're interested in.. isn't it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #40 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
CAN_user_catalogue is at the currently logged in user Ooooo crap sure, forget my comment ;)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 [Bug 26687] Add color to Font Awesome icon for superlibrarian patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #41 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111685&action=edit Bug 26687: Add color to Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to color this icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Update staff CSS (yarn build) 2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 3) Patron B has unchanged black shield icon 4) Patron A has red shield icon 5) Check a patron without permissions has no shield icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oups wrong bug in git-bz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #43 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #37)
I really like this and think it would be nice in other spots like the patron search as well. But this is a solid start. I'll try to work on that.
I've created Bug 26687 to color icon for superlibrarians B-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Isn't it weird to have a background colour only for staff users? Isn't the icon enough? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #44)
Isn't it weird to have a background colour only for staff users? Isn't the icon enough?
I think it makes it stand out a little more than only the small icon - I liked it, but opinions may vary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #47 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #44)
Isn't it weird to have a background colour only for staff users? Isn't the icon enough?
Class 'is-not-staff' on 'patroninfo' div allows an easy CSS tunning depending on staff/non-staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 --- Comment #48 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Thanks a lot everyone. This code is my little baby, will feel proud each time I see the little shield :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26879 [Bug 26879] Add font awesome icon for patrons in category of type Staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Font Awesome icon to |Add a Font Awesome icon to |help identify staff patrons |help identify staff patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #49 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds a small shield release notes| |icon to help identify staff | |members (having catalogue | |permission) in the staff | |interface. The icon | |displays next to the name | |on top of the brief patron | |information that is shown | |on all patron account | |pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org