[Bug 26687] New: Add color to Font Awesome icon for superlibrarian patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Bug ID: 26687 Summary: Add color to Font Awesome icon for superlibrarian patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to color this icon when patron is a superlibrarian. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED Depends on| |26534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 [Bug 26534] Add Font Awesome icon to help identify staff patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111686&action=edit Bug 26687: Add color to Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to color this icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Update staff CSS (yarn build) 2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 3) Patron B has unchanged black shield icon 4) Patron A has red shield icon 5) Check a patron without permissions has no shield icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111686|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111871&action=edit Bug 26687: Add color to Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to color this icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Update staff CSS (yarn build) 2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 3) Patron B has unchanged black shield icon 4) Patron A has red shield icon 5) Check a patron without permissions has no shield icon Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111871|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111875&action=edit Bug 26687: Add color to Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to color this icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Update staff CSS (yarn build) 2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 3) Patron B has unchanged black shield icon 4) Patron A has red shield icon 5) Check a patron without permissions has no shield icon Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice enhancement, works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor point.. I wonder if there's any more accessible ways of highlighting this too... we might find colour blindness issues.. I'm no expert. Either way I think that can be for another day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #5)
we might find colour blindness issues...
I agree and I should have considered that when testing. I suggest an alternate icon. Maybe https://fontawesome.com/v4.7.0/icon/star ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- I agree with Martin. It's been years since I delved into accessibility research, but I do recall that using colour as the sole signifier of something makes something less accessible. I like your idea, Owen, of using the star! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Maybe a superlibrarian should have the shield to denote staff status *plus* a star to denote superlibrarian status? That might also be a nice visual sanity check to make sure that only staff are superlibrarians heh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Martin Renvoize from comment #5)
we might find colour blindness issues...
I agree and I should have considered that when testing. I suggest an alternate icon. Maybe https://fontawesome.com/v4.7.0/icon/star ?
I agree that color is not the best. But I think we should keep star icon to mean 'favorite' or 'VIP' (like in many softwares). I'm searching another icon. Or maybe 2 shields ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Heeeee why not : https://fontawesome.com/v4.7.0/icon/superpowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolin SOMERS from comment #10)
That symbol doesn't mean anything to me! I guess it's a brand logo? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- https://fontawesome.com/v4.7.0/icon/bolt ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd be happy with either a different icon or a visible change on the background colour.. i.e some striped or zigzags or something.. both would satisfy the accessibility requirements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://fontawesome.com/icons/user-secret to throw another into the mix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #13)
I'd be happy with either a different icon or a visible change on the background colour.. i.e some striped or zigzags or something.. both would satisfy the accessibility requirements.
I could see people overriding background colour for customizations, so I'm not sure how practical that is. I could also see people complaining about stripes or zigzags, although I like the sound of them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #12)
+1 for that, its perfect. The Flash is a superlibarian XD. PS : People are used to "user-secret" as web-browser private navigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin SOMERS from comment #16)
(In reply to Owen Leonard from comment #12)
+1 for that, its perfect.
The Flash is a superlibarian XD.
PS : People are used to "user-secret" as web-browser private navigation.
I'm also +1 for "bolt" and I agree about "user-secret" being for private navigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111875|0 |1 is obsolete| | --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Comment on attachment 111875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111875 Bug 26687: Add color to Font Awesome icon for superlibrarian patrons I'll create a new patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 112140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112140&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add color to Font Awesome |Add a Font Awesome icon for |icon for superlibrarian |superlibrarian patrons |patrons | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 112141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112141&action=edit Bug 26687: Add a Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to add an icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 2) Patron B has only shield icon 3) Patron A has shield icon and bolt icon 4) Check a patron without permissions has no shield icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112141|0 |1 is obsolete| | --- Comment #21 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112245&action=edit Bug 26687: Add a Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to add an icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 2) Patron B has only shield icon 3) Patron A has shield icon and bolt icon 4) Check a patron without permissions has no shield icon Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112245|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112247&action=edit Bug 26687: Add a Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to add an icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 2) Patron B has only shield icon 3) Patron A has shield icon and bolt icon 4) Check a patron without permissions has no shield icon Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26879 [Bug 26879] Add font awesome icon for patrons in category of type Staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|Academy |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds a bolt icon next release notes| |to the shield icon | |introduced by bug 26534, if | |the user is not only a | |staff member but also holds | |the superlibrarian | |permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org