[Bug 17640] New: t/db_dependent/Template/Plugin/Categories.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Bug ID: 17640 Summary: t/db_dependent/Template/Plugin/Categories.t is failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57530&action=edit Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57530|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57537&action=edit Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57537|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57555&action=edit Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57556&action=edit Bug 17640: (QA followup) Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57555|0 |1 is obsolete| | Attachment #57556|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57557&action=edit Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57558&action=edit Bug 17640: (QA followup) Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57559&action=edit Bug 17640 [QA Followup] - Remove any outstanding issues before removing patrons Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57567&action=edit Bug 17640: (Jonathan complain followup) Use Koha::*->search->delete instead Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Second followup pushed to master, thanks again Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org