[Bug 17633] New: Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Bug ID: 17633 Summary: Tests should not call set_preference Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org If memcached is running, the pref's value will be set in cache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57507&action=edit Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17599 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Generated with perl -p -i -e "s/C4::Context->set_preference\((.*),(.*)\);/t::lib::Mocks::mock_preference(\1,\2);/" t/**/*.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57507|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57508&action=edit [SIGNED-OFF] Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57508|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57509&action=edit Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57510&action=edit Bug 17633: (QA followup) Remove unneeded warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57560&action=edit Bug 17633: (QA followup) remove debugging leftover Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Followup pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org