[Bug 37759] New: Duplicated "Set library" menu item caused by bad merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Bug ID: 37759 Summary: Duplicated "Set library" menu item caused by bad merge Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 In the rebasing of Bug 35402 I made a mistake in updating header.inc, including a section which should have been removed. This has caused a duplicate "Set library" menu item in the staff interface header. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170825&action=edit Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170825|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170837&action=edit Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170837|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170865&action=edit Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I tried to rebase, but now the "gear" icon does nothing. Can you please check yourself and rebase against latest master? Going to push a batch of changes in just a little bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170865|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170875&action=edit Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37759 Bug 37759 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org